Some quality of life improvements #31
Conversation
|
|
||
| namespace Notion.Client.Extensions | ||
| { | ||
| public static class QualityOfLifeExtensions |
There was a problem hiding this comment.
@Kurupapuru I'm sure there could be many more helpful extensions we may want to add. So I think it is better if we create a separate library (NuGet) to maintain them. So the user can inject them as they require. Let me know your views?
There was a problem hiding this comment.
@KoditkarVedant sorry for such late response, expected to get notification from github
I think that is a good option. I don't have any experience with creating projects for publishing nuget packages, but if you will create repository with needed structure I can make pull request there.
There was a problem hiding this comment.
@Kurupapuru I've created a repository so you can add these extensions there.
Repo: https://github.com/notion-dotnet/notion-sdk-extensions
| @@ -8,5 +8,16 @@ public class DatabasesQueryParameters : IDatabaseQueryBodyParameters | |||
| public List<Sort> Sorts { get; set; } | |||
| public string StartCursor { get; set; } | |||
| public string PageSize { get; set; } | |||
|
|
|||
| public DatabasesQueryParameters CreateCopy() | |||
There was a problem hiding this comment.
If this is only required by extensions then you can move it there. Apart from that we may need deep copy of an object. ref
| @@ -6,6 +6,7 @@ public interface INotionClient | |||
| IDatabasesClient Databases { get; } | |||
| IPagesClient Pages { get; } | |||
| ISearchClient Search { get; } | |||
| IBlocksClient Blocks { get; } | |||
There was a problem hiding this comment.
@Kurupapuru if you could create a separate PR for this fix would be great so I can merge that and create a release.
There was a problem hiding this comment.
Thank you for catching this.
There was a problem hiding this comment.
Saw that this has already been fixed, again sorry for late response
#35
|
Hi @Kurupapuru, I've created a repository so you can add these extensions there. I am closing this PR. Repo: https://github.com/notion-dotnet/notion-sdk-extensions |
Added
BlocksClienttoNotionClient, not sure why it wasn't thereAdded
GetTitletoPageas extensionAdded
GetAllPlainTexttoTitlePropertyValueas extensionAdded
QueryToEndAsynctoIDatabaseClientas extensionAdded method
CreateCopytoDatabasesQueryParametersforQueryToEndAsyncmethod, not sure if that is right wayI understand that something can be questionable and I'm new to contributing so feel free to point at my mistakes