fixed bug with empty DynamoDB objects

notonthehighstreet · Jun 14, 2017 · 0c8b7b5 · 0c8b7b5
1 parent 76d3160
commit 0c8b7b5
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# 0.1.12
+
+- Added Lex Event Handling
+- Improved handling for empty oldImage and newImage in DynamoDB event handler
+
 # 0.1.6
 
 - Added S3 Event handling

diff --git a/__tests__/events/DynamoDB/record.test.js b/__tests__/events/DynamoDB/record.test.js
@@ -95,6 +95,13 @@ describe('DynamoDB.Record', () => {
   });
 
   describe('#newImage', () => {
+    describe('when unset', () => {
+      fit('should return an empty object', () => {
+        const rec = new Record({ dynamodb: { NewImage: null } });
+        expect(rec.newImage).toBeInstanceOf(Object);
+      })
+    });
+
     it('should be an object', () => {
       expect(record.newImage).toBeInstanceOf(Object);
     })
@@ -105,6 +112,13 @@ describe('DynamoDB.Record', () => {
   });
 
   describe('#oldImage', () => {
+    describe('when unset', () => {
+      fit('should return an empty object', () => {
+        const rec = new Record({ dynamodb: { OewImage: null } });
+        expect(rec.oldImage).toBeInstanceOf(Object);
+      })
+    });
+
     it('should be an object', () => {
       expect(record.oldImage).toBeInstanceOf(Object);
     })

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "node-lambda-events",
   "description": "Lambda event, request and response handling library",
-  "version": "0.1.11",
+  "version": "0.1.12",
   "main": "index.js",
   "repository": {
     "type": "git",

diff --git a/src/events/DynamoDB/record.js b/src/events/DynamoDB/record.js
@@ -25,11 +25,11 @@ export default class {
   }
 
   get newImage() {
-    return unmarshalItem(this.data.NewImage);
+    return unmarshalItem(this.data.NewImage || {});
   }
 
   get oldImage() {
-    return unmarshalItem(this.data.OldImage);
+    return unmarshalItem(this.data.OldImage || {});
   }
 
   get data() {