Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable 2069-style weak Digest auth by default #23

Closed
notroj opened this issue Jun 9, 2020 · 0 comments
Closed

Disable 2069-style weak Digest auth by default #23

notroj opened this issue Jun 9, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@notroj
Copy link
Owner

notroj commented Jun 9, 2020

RFC2617 is out for two decades; 2069-style Digest auth should not be supported for NE_AUTH_DEFAULT in 0.32.

An NE_AUTH_WEAK_DIGEST or similar can be defined to restore it explicitly.
@notroj notroj added the enhancement New feature or request label Jun 9, 2020
notroj added a commit that referenced this issue Jul 11, 2020
@notroj
Disable weak (RFC2069) Digest by default, unless NE_AUTH_WEAK_DIGEST
a7d54a8 
is used.  Closes #23.

* src/ne_auth.h: Define NE_AUTH_WEAK_DIGEST.

* src/ne_auth.c (digest_challenge): Fail if qop=auth is not present
  and WEAK_DIGEST is not enabled.
  (auth_register): NE_AUTH_WEAK_DIGEST implies NE_AUTH_DIGEST
  to retain binary backwards compatibility.

* test/auth.c (test_digest, digest, digest_failures): Test for
  2069-style auth with WEAK_DIGEST, test compat mode, test for new
  failure mode.
@notroj notroj closed this as completed in 5ebdbe1 Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notroj