Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preference order for Digest auth challenges #26

Closed
notroj opened this issue Jun 18, 2020 · 0 comments
Closed

Preference order for Digest auth challenges #26

notroj opened this issue Jun 18, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@notroj
Copy link
Owner

notroj commented Jun 18, 2020

If the server sends multiple Digest challenges these should be tried in strength order. Currently the ordering is only by protocol (i.e. Digest > Basic) but not by algorithm strength within that protocol.
@notroj notroj added the bug Something isn't working label Jun 18, 2020
notroj added a commit that referenced this issue Jul 6, 2020
@notroj
Handle Digest challenges in algorithm strength order (issue #26):
9a767a9 
* src/ne_auth.c (insert_challenge): Take the challenge as an argument
  and adjust to sort by Digest algorithm as well as challenge
  strength.
  (auth_challenge): Adjust to allocate challenge first, and insert later
  as above.

* test/auth.c (init): New function.
  (multi_rfc7616): New test case.
notroj added a commit that referenced this issue Jul 6, 2020
@notroj
Handle Digest challenges in algorithm strength order (issue #26):
2ec512d 
* src/ne_auth.c (insert_challenge): Take the challenge as an argument
  and adjust to sort by Digest algorithm as well as challenge
  strength.
  (auth_challenge): Adjust to allocate challenge first, and insert later
  as above.

* test/auth.c (init): New function.
  (multi_rfc7616): New test case.
@notroj notroj mentioned this issue Jul 6, 2020
Merged
@notroj notroj closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notroj