Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax strictness of usernames allowed with Digest without requiring #79

Merged
merged 1 commit into from Jul 11, 2022
Merged

Relax strictness of usernames allowed with Digest without requiring #79

merged 1 commit into from Jul 11, 2022

Conversation

notroj
Copy link
Owner

@notroj notroj commented Jul 4, 2022 

Relax strictness of usernames allowed with Digest without requiring userhash/ext-param quoting (closes #78):

* src/ne_auth.c (unsafe_username): New function.
  (get_digest_h_urp): Use it, rather than ne_strparam() to
  determine whether the passed username is safe to use quoted.

* test/auth.c (digest_username_star): Test for @ in usernames.

@notroj
Relax strictness of usernames allowed with Digest without requiring
e554d22 
userhash/ext-param quoting (closes #78):

* src/ne_auth.c (unsafe_username): New function.
  (get_digest_h_urp): Use it, rather than ne_strparam() to
  determine whether the passed username is safe to use quoted.

* test/auth.c (digest_username_star): Test for @ in usernames.
@notroj notroj mentioned this pull request Jul 4, 2022
Closed
@notroj notroj merged commit 93faea8 into master Jul 11, 2022
@notroj notroj deleted the digest-relaxed-usernames branch July 11, 2022 07:10
martinprikryl added a commit to winscp/winscp that referenced this pull request Jul 12, 2022
@martinprikryl
Official Neon fix for Bug 2095 (Cannot authenticate to WebDAV server …
0c65ce6 
…with username containing some special characters)

notroj/neon#79

Source commit: 2101c7c24e8d986609b660b5b75856234986e7d1
martinprikryl added a commit to winscp/winscp that referenced this pull request Jul 12, 2022
@martinprikryl
Official Neon fix for Bug 2095 (Cannot authenticate to WebDAV server …
31483aa 
…with username containing some special characters)

notroj/neon#79
(cherry picked from commit 0c65ce6)

Source commit: 4e078153d750b1321f95bdf5465bf5dce3733d68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@notroj