Support Ruby's standard behavior on custom exceptions #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby's standard behavior for Exception#inspect is to show <ExceptionClass: ExceptionClass> when no message is given and <ExceptionClass: message> if a message is given. Custom exceptions should reflect this behavior.
nov
added a commit
that referenced
this pull request
Feb 6, 2012
Support Ruby's standard behavior on custom exceptions
nov
added a commit
that referenced
this pull request
Feb 6, 2012
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby's standard behavior for Exception#inspect is to show <ExceptionClass: ExceptionClass>
when no message is given and <ExceptionClass: message> if a message is given. Custom exceptions
should reflect this behavior.
The problem is fairly obvious when, for instance, using Resque: Instead of displaying the (helpful) Facebook error message, one merely gets "FbGraph::InvalidRequest" which is not helpful for debugging/bugfixing at all. The pull request fixes this issue by calling super at the end.