Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to choose subtitle #643

Closed
kralcak opened this issue May 25, 2022 · 15 comments
Closed

Unable to choose subtitle #643

kralcak opened this issue May 25, 2022 · 15 comments
Assignees
Labels
bug Something isn't working Important Bug severity

Comments

@kralcak
Copy link

kralcak commented May 25, 2022

When playing local mkv tv show with many subtitle tracks included inside the file I can choose only first 32 subtitle tracks. I can't choose any subtitle files which are stored together with the movie in same directory nor any subtitle which I download from open subtitles. Please change the limit from 32 to at least 50.

@courville courville self-assigned this Jun 19, 2022
@courville
Copy link
Contributor

Thanks for reporting.
I do not see obvious hard limit to 25 in the code (yet).
Could you please provide a file with 50 subs for me to test and debug (or at least the exact file name so that I can download it)?

@courville courville added the bug Something isn't working label Jun 19, 2022
@courville
Copy link
Contributor

I checked a 26 subs embedded file and selecting sub 26 works (you need to wait for the buffer flush on current sub read though or seek).

@moneytoo
Copy link

When I tried a file with 34 subtitle tracks, only 32 showed - https://www.reddit.com/r/NovaVideoPlayer/comments/swrq1g/up_to_32_internal_subtitles_supported/

@courville
Copy link
Contributor

courville commented Jun 19, 2022

@moneytoo this is another issue.
Could you please provide a file (exact file name would do)?

EDIT: I have found one file with 32 subs.

FTR I can change sub track on all the 34 ones (after a seek).

@courville
Copy link
Contributor

OK thus for now I will classify the issue as "works for me (tm)".
Please react with more actionable inputs so that I do not close the issue.

@bladyle
Copy link

bladyle commented Jul 10, 2022

Same issue here. I have file with 30+ integrated subtitles and my subtitle is on the storage. I can choose it but it won't show in the list if if there are too many integrated subs.

@moneytoo
Copy link

Here's a sample with 36 subtitle tracks. I'm unable to select last 4 subtitle tracks (Ukrainian, Vietnamese and Chinese Simplified/Traditional) in Nova 6.0.71.

mn-sample.zip

@hongfengfeiyang999
Copy link

Here's a sample with 36 subtitle tracks. I'm unable to select last 4 subtitle tracks (Ukrainian, Vietnamese and Chinese Simplified/Traditional) in Nova 6.0.71.

mn-sample.zip

I am also unable to display external subtitles

@Unix-Kernel
Copy link

Unix-Kernel commented Aug 22, 2022

Yeap, I can confirm that the last four subtitles will "not" show/display in the scraped page or when the video is playing, it only shows the first 32-subtitles, all other subtitles after that are not available.

@allonli
Copy link

allonli commented Oct 27, 2022

this bug still exists in the current version. 2022.10.27

@wawava
Copy link

wawava commented Nov 13, 2022

this bug still exists in the v6.0.82 release,please fix it

@wawava
Copy link

wawava commented Nov 13, 2022

maybe 34 is not enough ,i see one video ,it's have 44 subtitles
if you need test ,pelase down the video though bt v6.0.82 release

@courville courville added the Important Bug severity label Nov 13, 2022
@courville
Copy link
Contributor

courville commented Nov 13, 2022

I am able to reproduce the issue with @moneytoo mn-sample file on leanback interface.
In avos:

av.h:#define SUB_TRACK_MAX		32

courville added a commit to nova-video-player/aos-avos that referenced this issue Nov 13, 2022
@courville
Copy link
Contributor

Works on mn-sample file. Will be released on github later today as 6.0.83.

@courville
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Important Bug severity
Projects
None yet
Development

No branches or pull requests

8 participants