Integrate various fixes so Novacoin builds on OSX

[jyap808]

My changes fix various build issues on OSX.

[jyap808]

Thanks!

[0xDEADFACE]

Unfortunately, there are some issues with building on other platforms:

g++ -c -O2  -pthread -Wall -Wextra -Wno-ignored-qualifiers -Wformat -Wformat-security -Wno-unused-parameter -g -DBOOST_SPIRIT_THREADSAFE -I/home/deadface/git-repo/novacoin-project/test/novacoin/src -I/home/deadface/git-repo/novacoin-project/test/novacoin/src/obj -DUSE_UPNP=0 -DUSE_IPV6=1 -I/home/deadface/git-repo/novacoin-project/test/novacoin/src/leveldb/include -I/home/deadface/git-repo/novacoin-project/test/novacoin/src/leveldb/helpers -DHAVE_BUILD_INFO -fno-stack-protector -fstack-protector-all -Wstack-protector -D_FORTIFY_SOURCE=2  -MMD -MF obj/init.d -o obj/init.o init.cpp
In file included from init.h:8:0,
                 from init.cpp:9:
wallet.h: In member function 'unsigned int CAccountingEntry::GetSerializeSize(int, int) const':
wallet.h:825:5: error: no matching function for call to 'CDataStream::insert(CDataStream::iterator, std::vector<char>::const_iterator, std::vector<char>::const_iterator)'
wallet.h:825:5: note: candidates are:
serialize.h:811:14: note: CDataStream::iterator CDataStream::insert(CDataStream::iterator, const char&)
serialize.h:811:14: note:   candidate expects 2 arguments, 3 provided
serialize.h:812:10: note: void CDataStream::insert(CDataStream::iterator, CDataStream::size_type, const char&)
serialize.h:812:10: note:   no known conversion for argument 2 from 'std::vector<char>::const_iterator {aka __gnu_cxx::__normal_iterator<const char*, std::vector<char> >}' to 'CDataStream::size_type {aka long unsigned int}'
serialize.h:814:10: note: void CDataStream::insert(CDataStream::iterator, CDataStream::const_iterator, CDataStream::const_iterator)
serialize.h:814:10: note:   no known conversion for argument 2 from 'std::vector<char>::const_iterator {aka __gnu_cxx::__normal_iterator<const char*, std::vector<char> >}' to 'CDataStream::const_iterator {aka __gnu_cxx::__normal_iterator<const char*, std::vector<char, zero_after_free_allocator<char> > >}'
serialize.h:829:10: note: void CDataStream::insert(CDataStream::iterator, const char*, const char*)
serialize.h:829:10: note:   no known conversion for argument 2 from 'std::vector<char>::const_iterator {aka __gnu_cxx::__normal_iterator<const char*, std::vector<char> >}' to 'const char*'
wallet.h: In member function 'void CAccountingEntry::Serialize(Stream&, int, int) const':
wallet.h:825:5: error: no matching function for call to 'CDataStream::insert(CDataStream::iterator&, std::vector<char>::const_iterator&, std::vector<char>::const_iterator&)'
wallet.h:825:5: note: candidates are:
serialize.h:811:14: note: CDataStream::iterator CDataStream::insert(CDataStream::iterator, const char&)
serialize.h:811:14: note:   candidate expects 2 arguments, 3 provided
serialize.h:812:10: note: void CDataStream::insert(CDataStream::iterator, CDataStream::size_type, const char&)
serialize.h:812:10: note:   no known conversion for argument 2 from 'std::vector<char>::const_iterator {aka __gnu_cxx::__normal_iterator<const char*, std::vector<char> >}' to 'CDataStream::size_type {aka long unsigned int}'
serialize.h:814:10: note: void CDataStream::insert(CDataStream::iterator, CDataStream::const_iterator, CDataStream::const_iterator)
serialize.h:814:10: note:   no known conversion for argument 2 from 'std::vector<char>::const_iterator {aka __gnu_cxx::__normal_iterator<const char*, std::vector<char> >}' to 'CDataStream::const_iterator {aka __gnu_cxx::__normal_iterator<const char*, std::vector<char, zero_after_free_allocator<char> > >}'
serialize.h:829:10: note: void CDataStream::insert(CDataStream::iterator, const char*, const char*)
serialize.h:829:10: note:   no known conversion for argument 2 from 'std::vector<char>::const_iterator {aka __gnu_cxx::__normal_iterator<const char*, std::vector<char> >}' to 'const char*'
wallet.h: In member function 'void CAccountingEntry::Unserialize(Stream&, int, int)':
wallet.h:825:5: error: no matching function for call to 'CDataStream::insert(CDataStream::iterator&, std::vector<char>::iterator&, std::vector<char>::iterator&)'
wallet.h:825:5: note: candidates are:
serialize.h:811:14: note: CDataStream::iterator CDataStream::insert(CDataStream::iterator, const char&)
serialize.h:811:14: note:   candidate expects 2 arguments, 3 provided
serialize.h:812:10: note: void CDataStream::insert(CDataStream::iterator, CDataStream::size_type, const char&)
serialize.h:812:10: note:   no known conversion for argument 2 from 'std::vector<char>::iterator {aka __gnu_cxx::__normal_iterator<char*, std::vector<char> >}' to 'CDataStream::size_type {aka long unsigned int}'
serialize.h:814:10: note: void CDataStream::insert(CDataStream::iterator, CDataStream::const_iterator, CDataStream::const_iterator)
serialize.h:814:10: note:   no known conversion for argument 2 from 'std::vector<char>::iterator {aka __gnu_cxx::__normal_iterator<char*, std::vector<char> >}' to 'CDataStream::const_iterator {aka __gnu_cxx::__normal_iterator<const char*, std::vector<char, zero_after_free_allocator<char> > >}'
serialize.h:829:10: note: void CDataStream::insert(CDataStream::iterator, const char*, const char*)
serialize.h:829:10: note:   no known conversion for argument 2 from 'std::vector<char>::iterator {aka __gnu_cxx::__normal_iterator<char*, std::vector<char> >}' to 'const char*'
make: *** [obj/init.o] Error 1
deadface@deadface-PC:~/git-repo/novacoin-project/test/novacoin/src$ 

I guess that it was caused by the differences between used boost versions. I have to rollback this commit, until the reason of this errors will be properly analyzed. :(

By the way, novacoin builds fine on OS X using this environment:

• Mac OS X 10.7
• libminiupnpc-1.6
• libqrencode-3.4.3
• libdb 4.8.30
• Qt 4.8.4
• g++ 4.2.1 (LLVM build 2336.11.00)

[jyap808]

Hi, everything works fine for me with my changes compiling with:
make -f makefile.unix

Tested on:

• Ubuntu 12.04.4 LTS (GNU/Linux 3.5.0-45-generic x86_64)
• libboost-dev 1.48.0.2
• libminiupnpc-dev 1.6-3ubuntu1
• libdb5.1-dev 5.1.25-11build1
• g++-4.6 4.6.3-1ubuntu5

[kha0S]

Hi.
It fails on all my Debian machines.

Tested on:

• Debian testing
• libboost-dev 1.51 / 1.53
• libminiupnpc-dev 1.5-2
• libdb5.3-dev 5.3-28
• g++ 4.8.2-14

[jyap808]

Thanks for posting the details of your testing environment.