Fallback controller #192
Merged
Fallback controller #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taure
approved these changes
Oct 13, 2022
burbas
force-pushed
the
fallback-contrller
branch
from
f8c4f08
to
d0b4157
Compare
burbas
force-pushed
the
fallback-contrller
branch
from
5ed6f53
to
1442825
Compare
|
@Taure Please review the latest changes and if everything looks alright we can merge it into master |
burbas
added
enhancement
|
Will test this branch and merge when tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phoenix have a very neat way of handling non-expected results of a controller via a fallback controller (https://hexdocs.pm/phoenix/Phoenix.Controller.html#action_fallback/1). This commit includes a similar way of handling this.
A fallback controller is defined by setting the attribute
fallback_controllerin a controller. If a non-expected result is returned from the controller then the fallback_controllersresolve/2function is called with the argumentsReq :: cowboy_req(), ControllerOutput :: any()where the ControllerOutput is result of executing the controller.There's a few things to fix before we can merge this PR: