Add Meta Key mapping to xtscancodes.js #654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively. This change will allow the Super/Windows key to be used under the qemu rfb extension under Chrome and updated browsers. w3c/uievents-code#7 https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code
|
Do we need to keep the old names for some sort of compatibility? |
|
Yes, I would leave it for compatibility. https://bugzilla.mozilla.org/show_bug.cgi?id=1264150 is still open for firefox, even though they have updated their docs, it still sends the code "OSLeft" or "OSRight". That's actually how i discovered the bug in the first place, it worked fine under firefox. |
|
Ok, could you add a comment to OSLeft and OSRight which explains the situation and I'll merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively.
This change will allow the Super/Windows key to be used under the qemu rfb extension under Chrome and updated browsers.
w3c/uievents-code#7
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code