New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename OSLeft/Right to MetaLeft/Right #7
Comments
To clarify, we currently have:
And one of these things is not like the others: Meta and OSLeft/Right is clearly an oddball. With this change, we would have:
|
asadpanda
added a commit
to asadpanda/noVNC
that referenced
this issue
Sep 6, 2016
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively. This change will allow the Super/Windows key to be used under the qemu rfb extension under Chrome and updated browsers. w3c/uievents-code#7 https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code
samhed
pushed a commit
to novnc/noVNC
that referenced
this issue
Oct 19, 2016
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively. This change will allow the Super/Windows key to be used under the qemu rfb extension under Chrome and updated browsers. w3c/uievents-code#7 https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code
chinnkarahoi
pushed a commit
to chinnkarahoi/noVNC
that referenced
this issue
Apr 11, 2022
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively. This change will allow the Super/Windows key to be used under the qemu rfb extension under Chrome and updated browsers. w3c/uievents-code#7 https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code
chinnkarahoi
pushed a commit
to chinnkarahoi/noVNC
that referenced
this issue
Jan 27, 2023
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively. This change will allow the Super/Windows key to be used under the qemu rfb extension under Chrome and updated browsers. w3c/uievents-code#7 https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since we renamed 'OS' to 'Meta' in for the |key| values, it makes sense to do the same for the |code| values.
Making this change would make all the modifier keys consistent between |key|, |code| and the modifier flags.
The text was updated successfully, but these errors were encountered: