Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OSLeft/Right to MetaLeft/Right #7

Closed
Tracked by #27459
garykac opened this issue Nov 22, 2015 · 1 comment
Closed
Tracked by #27459

Rename OSLeft/Right to MetaLeft/Right #7

garykac opened this issue Nov 22, 2015 · 1 comment

Comments

@garykac
Copy link
Member

garykac commented Nov 22, 2015

Since we renamed 'OS' to 'Meta' in for the |key| values, it makes sense to do the same for the |code| values.

Making this change would make all the modifier keys consistent between |key|, |code| and the modifier flags.

@garykac
Copy link
Member Author

garykac commented Nov 22, 2015

To clarify, we currently have:

key = Control; code = ControlLeft, ControlRight
key = Shift; code = ShiftLeft, ShiftRight
key = Alt; code = AltLeft, AltRight
key = Meta; code = OSLeft, OSRight

And one of these things is not like the others: Meta and OSLeft/Right is clearly an oddball.

With this change, we would have:

key = Control; code = ControlLeft, ControlRight
key = Shift; code = ShiftLeft, ShiftRight
key = Alt; code = AltLeft, AltRight
key = Meta; code = MetaLeft, MetaRight

asadpanda added a commit to asadpanda/noVNC that referenced this issue Sep 6, 2016
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively.

This change will allow the Super/Windows key to be used under the qemu rfb extension under Chrome and updated browsers.

w3c/uievents-code#7
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code
samhed pushed a commit to novnc/noVNC that referenced this issue Oct 19, 2016
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively.
This change will allow the Super/Windows key to be used under the qemu
rfb extension under Chrome and updated browsers.

w3c/uievents-code#7
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code
chinnkarahoi pushed a commit to chinnkarahoi/noVNC that referenced this issue Apr 11, 2022
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively.
This change will allow the Super/Windows key to be used under the qemu
rfb extension under Chrome and updated browsers.

w3c/uievents-code#7
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code
chinnkarahoi pushed a commit to chinnkarahoi/noVNC that referenced this issue Jan 27, 2023
OSLeft/OSRight have been renamed to MetaLeft/MetaRight respectively.
This change will allow the Super/Windows key to be used under the qemu
rfb extension under Chrome and updated browsers.

w3c/uievents-code#7
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant