MVI ViewModel #59
Merged
MVI ViewModel #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mvi_reducer: Remove not needed null check Change changes to be a PublishSubject Use scan operator to reduce changes to a state Change wording to highlight that the query is updated add hideLoading and removeResults actions Expect SearchMiddleware to hide progress Move domain agnostic screen state and screen state changes from domain specific middleware to the reducer Rename domain specific changes to domain agnostic screen state changes # Conflicts: # ModelViewIntentSample/search/src/main/java/com/novoda/movies/mvi/search/domain/SearchDependencyProvider.kt # ModelViewIntentSample/search/src/main/java/com/novoda/movies/mvi/search/domain/SearchMiddleware.kt # ModelViewIntentSample/search/src/main/java/com/novoda/movies/mvi/search/presentation/SearchActivity.kt # ModelViewIntentSample/search/src/test/java/com/novoda/movies/mvi/search/domain/SearchMiddlewareTest.kt
gbasile
commented
Sep 5, 2019
| @@ -40,17 +40,17 @@ class BaseStore<A, S, C>( | |||
| return disposables | |||
| } | |||
|
|
|||
| override fun bind(view: MVIView<A, S>): Disposable { | |||
| override fun bind(actionProvider: ActionProvider<A>, viewRender: ViewRender<S>): Disposable { | |||
gbasile
commented
Sep 5, 2019
| private val reducer: Reducer<S, C>, | ||
| private val middlewares: List<Middleware<A, S, C>>, | ||
| private val initialValue: S | ||
| private val schedulingStrategy: SchedulingStrategy, |
There was a problem hiding this comment.
What do I need to have a consistent indenting with the rest of the project?
There was a problem hiding this comment.
Did you import the novoda code styles from https://github.com/novoda/novoda/tree/master/ide-settings/intellij ?
tobiasheine
reviewed
Sep 9, 2019
| private val reducer: Reducer<S, C>, | ||
| private val middlewares: List<Middleware<A, S, C>>, | ||
| private val initialValue: S | ||
| private val schedulingStrategy: SchedulingStrategy, |
There was a problem hiding this comment.
Did you import the novoda code styles from https://github.com/novoda/novoda/tree/master/ide-settings/intellij ?
| @@ -9,8 +9,7 @@ | |||
| android:roundIcon="@mipmap/ic_launcher_round" | |||
| android:supportsRtl="true" | |||
| android:theme="@style/AppTheme"> | |||
| <activity android:name=".presentation.SearchActivity" | |||
| android:screenOrientation="portrait"/> | |||
ModelViewIntentSample/search/src/main/java/com/novoda/movies/mvi/search/data/SearchBackend.kt
Outdated
Show resolved
Hide resolved
...ntentSample/search/src/main/java/com/novoda/movies/mvi/search/presentation/SearchActivity.kt
Outdated
Show resolved
Hide resolved
| import com.novoda.movies.mvi.search.domain.SearchReducer | ||
| import io.reactivex.disposables.Disposable | ||
|
|
||
| internal typealias SearchStore = BaseStore<SearchActivity.Action, SearchActivity.State, SearchReducer.Changes> |
tobiasheine
approved these changes
Sep 9, 2019
tobiasheine
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the UI state is preserved after the Activity is destroyed (for example after a rotation)
Some housekeeping:
ViewRenderandActionProviderfor better flexibility