Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVI ViewModel #59

Merged
merged 17 commits into from
Sep 10, 2019
Merged

MVI ViewModel #59

merged 17 commits into from
Sep 10, 2019

Commits on Aug 1, 2019

  1. create abstraction fort the MovieDataSource

    @gbasile
    gbasile committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    3b72d11 View commit details
    Browse the repository at this point in the history

  2. split render and action provider out of a single interface

    @gbasile
    gbasile committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    8594308 View commit details
    Browse the repository at this point in the history

  3. use viewModel to allows state to survive device rotation

    @gbasile
    gbasile committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    24f4df2 View commit details
    Browse the repository at this point in the history

  4. handle loading

    @gbasile
    gbasile committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    b65314b View commit details
    Browse the repository at this point in the history

  5. handling error states

    @gbasile
    gbasile committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    aea3e85 View commit details
    Browse the repository at this point in the history

  6. avoid unnecessary refreshes of the input field

    @gbasile
    gbasile committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    033fbe0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Merge branch 'mvi_reducer' into mvi_view_model 

    * mvi_reducer:
  Remove not needed null check
  Change changes to be a PublishSubject
  Use scan operator to reduce changes to a state
  Change wording to highlight that the query is updated
  add hideLoading and removeResults actions
  Expect SearchMiddleware to hide progress
  Move domain agnostic screen state and screen state changes from domain specific middleware to the reducer
  Rename domain specific changes to domain agnostic screen state changes

# Conflicts:
#	ModelViewIntentSample/search/src/main/java/com/novoda/movies/mvi/search/domain/SearchDependencyProvider.kt
#	ModelViewIntentSample/search/src/main/java/com/novoda/movies/mvi/search/domain/SearchMiddleware.kt
#	ModelViewIntentSample/search/src/main/java/com/novoda/movies/mvi/search/presentation/SearchActivity.kt
#	ModelViewIntentSample/search/src/test/java/com/novoda/movies/mvi/search/domain/SearchMiddlewareTest.kt
    @gbasile
    gbasile committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    eaceff7 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. renamed viewRender to Displayer

    @gbasile
    gbasile committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    df90942 View commit details
    Browse the repository at this point in the history

  2. automatic wiring

    @gbasile
    gbasile committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    2dfbca7 View commit details
    Browse the repository at this point in the history

  3. Displayer implement actionProvider and render

    @gbasile
    gbasile committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    f9a219e View commit details
    Browse the repository at this point in the history

  4. scope types

    @gbasile
    gbasile committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    0e80ea2 View commit details
    Browse the repository at this point in the history

  5. simplify VM logic

    @gbasile
    gbasile committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    7c5a2ad View commit details
    Browse the repository at this point in the history

  6. added import

    @gbasile
    gbasile committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    cb5648c View commit details
    Browse the repository at this point in the history

  7. removed extra lines

    @gbasile
    gbasile committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    bea331c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Moved scope for State and Action into the ViewModel

    @gbasile
    gbasile committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    efebcc1 View commit details
    Browse the repository at this point in the history

  2. removed abstraction

    @gbasile
    gbasile committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    2c0d3e2 View commit details
    Browse the repository at this point in the history

  3. reverted variable names

    @gbasile
    gbasile committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    2e02c6c View commit details
    Browse the repository at this point in the history