This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Small fix - check task not found on empty project #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject setup. When nothing is setup, except for resolving `check` task, the plugin is no-op. Right now, resolving `check` would break on an empty project with unclear error. This PR fixes that and make setting up check task optional
mr-archano
approved these changes
May 12, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAP automatically configures itself when it detects other tools and project setup.
When nothing is setup, (except for resolving
checktask), the plugin is no-op.Right now, resolving
checkwould break on an empty project with unclear error.This PR fixes that and make setting up check task optional
Wrote a failing test first 👇
