This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the docs to indicate that we support version 6 and above
Remove afterEvaluate together with support for older versions of Ktlint plugin
…ugin into develop
…roject setup. When nothing is setup, except for resolving `check` task, the plugin is no-op. Right now, resolving `check` would break on an empty project with unclear error. This PR fixes that and make setting up check task optional
Small fix - check task not found on empty project
Introduce lazy tasks except for ktlint
Bug fix: define closure strategy
Use new detekt features and remove 1 year old versions support
Update samples
We needed to drop support for ktlint 6.1.0 Also 7.0.0 is failing on Ktlint side now only on Kotlin only projects
Also point to internal docs. Those internal docs already have links to external project pages. So it makes sense to keep the main page internal for easier navigation.
Lazy Task Configuration for ktlint
Prepare release 1.0
mr-archano
suggested changes
May 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tasomaniac I realised that I haven't migrated the release script to use the new Bintray account. I will issue a small PR against develop
and re-open this once ready.
Thanks for all your support, I hope it will be fine to wait few more hours for this.
|
Looks great. Feel free to change the description of this PR 😊 I think I was very lazy when I opened it. |
mr-archano
approved these changes
May 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.0
I thought it would be cool to do 1.0 now since the project is pretty solid and has 100% task configuration avoidance support.
Changelog
evaluateViolations
orcheck
task is run explicitly, no task will be configured eagerly.6.2.1
1.0.0.RC9.2