Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Update samples #188

Merged
merged 3 commits into from May 16, 2019
Merged

Update samples #188

merged 3 commits into from May 16, 2019

Conversation

tasomaniac
Copy link
Contributor

  • Update sample dependencies to latest versions to be able to showcase lazy task configuration

  • Renamed buildpropertiesplugin copy pasta :)

  • Fix a small issue with Findbugs

    • I think this was not picked up by tests because it is Gradle 5 behavior change.
    • I got Task with name 'collectFindbugsDebugUnitTestViolations' not found while configuring html generation task for findbugs.

@@ -1,6 +1,6 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
package="com.novoda.buildpropertiesplugin.sample">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦊

@tasomaniac tasomaniac merged commit 7b2c361 into develop May 16, 2019
@tasomaniac tasomaniac deleted the taso/update-sample branch May 16, 2019 22:23
@tasomaniac tasomaniac mentioned this pull request May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants