Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

[PT-503] Detekt Integration Bugs #49

Merged
merged 4 commits into from Jan 26, 2018
Merged

[PT-503] Detekt Integration Bugs #49

merged 4 commits into from Jan 26, 2018

Conversation

tobiasheine
Copy link
Contributor

@tobiasheine tobiasheine commented Jan 26, 2018 •
edited

PT-503

Description

While testing the integration in the wild we found two bugs:

  • the detekt reports are not picked up for evaluation
  • the link to the html report is wrong

Considerations

  • generate path to report file by using project.file() with the relative path. This was working in the tests since we are using an absolute path
  • make htmlReportFile configurable since detekt names the html report different than the xml report.

Tests

  • added a test to verify the link to the html report is correct

Paired with @tasomaniac

@tasomaniac
Copy link
Contributor

Merging since it resolves bugs.

@tasomaniac tasomaniac merged commit 1277aef into PT-491/integrate_detekt Jan 26, 2018
@tasomaniac tasomaniac deleted the PT-503/detekt_reports_are_not_picked_up branch January 26, 2018 14:06
@tobiasheine tobiasheine mentioned this pull request Feb 1, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tasomaniac tasomaniac tasomaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobiasheine @tasomaniac