Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

[PT-491]: Integrate Detekt #58

Merged
merged 89 commits into from Jan 31, 2018
Merged

[PT-491]: Integrate Detekt #58

merged 89 commits into from Jan 31, 2018

Conversation

tobiasheine
Copy link
Contributor

@tobiasheine tobiasheine commented Jan 31, 2018 •
edited

PT-491

Description

Scope of this PR is to merge the detekt feature branch back to develop.

Support for Kotlin Projects: #46
Support for Android Kotlin Projects: #48
Configuration: #47
Bugfixes: #49
Documentation: #54

The next steps will be:

  • split up readme
  • merge Android Lint integration to develop (which is based on this branch)
  • release 0.5 including Detekt and Android Lint 🎉

@tobiasheine
Add TestKotlinProject to setup a test kotlin project
ee20ebf
@tobiasheine
Support multiple plugins for test projects
26b52d4
@tobiasheine
Add detekt kotlin fixtures
1aa8d83
@tobiasheine
Expose kotlin test project rule
6bb5a1f
@tobiasheine
Add kotlin support to TestKotlinProject
9d7b9d1
@tobiasheine
Expose projectDir to configure an output dir for detekt used in the t…
3c03ba4 
…ests
@tobiasheine
Add DetektIntegrationTest which verifies the build fails when detekt …
a87451e 
…warnings exceed threshold
@tobiasheine
Simplify Warning Fixture
54f982b
@tobiasheine
Add skeleton for DetektConfigurator
e1d1512
@tobiasheine
Add detekt to test project classpath
44c2b08
@tobiasheine
Apply detekt plugin in case the project has kotlin configured
913a6e7
@tobiasheine
Apply detekt configuration to the detekt extension
5b775fe
@tobiasheine
Fix broken Fixture path
432bc1f
@tobiasheine
Add empty line to fixture file in order to suppress not wanted detekt…
b00ed49 
… style warning
@tobiasheine
Add CollectDetektViolationsTask
3903089
@tobiasheine
Configure detekt task to collect violations
fdd3756
@tobiasheine
Revert Fixture path change
f5c85ca
@tobiasheine
Link detekt report file to CollectDetektViolationsTask
c61e8e2
@tobiasheine
Remove not needed public keyword
c9af099
@tobiasheine
Extract common Configurator interface
eea5b69
@tobiasheine
Create DetektConfigurator as part of other Configurators
0bc714d
@tobiasheine
Add a test case to verify the the build fails when detekt errors are …
9b4cf95 
…over threshold
@tobiasheine
Verify the build does not fail in case detekt is not configured or th…
1b2a154 
…resholds are not exceeded
@tobiasheine
Should not fail when no warnings or errors threshold trespassed
5b52771
@tobiasheine
Remove empty line
9249690
@tobiasheine
Rename field
faee71d
@tobiasheine
Rename class
7a82512
@tobiasheine
Simplify task access
4030061
@tobiasheine
Fix wrong generic type
64405bb
@tobiasheine
Add comment which might be useful for other developers
70b7b2f
rock3r and others added 23 commits January 30, 2018 15:29
@rock3r
Simplify README, point to pages in docs/
accf4fc
@rock3r
Add missing whiteline at EOF in NOTICE
7c43d55
@rock3r
Fix Android Lint support matrix
d4c6ef0
@rock3r
Add documentation for the Checkstyle plugin
ce97e86
@rock3r
Add instructions for enabling/disabling tools
1b32738
@rock3r
Use defaults in config in the README file
e0e5ff4
@rock3r
Tweak Detekt missing exception message
40cba31
@rock3r
Update Missing Detekt message in tests
4696307
@rock3r
Add documentation for all tools to supported-tools
0577d74
@tasomaniac
Fix typo
9cc5780
@tasomaniac
Merge pull request #53 from novoda/tweak-detekt-exception-message
4160752 
Tweak Detekt missing exception message
@rock3r
Merge branch 'PT-491/integrate_detekt' into add_detekt_and_reorganise…
f7074d1 
…_readme
@rock3r
Fix grammar in error message
fb10e7f
@rock3r
Cleanup DetektConfigurator
f0d2803
@rock3r
Cleanup LogsSubject
2a02420
@mr-archano
Merge pull request #57 from novoda/tweak-detekt-exception-message
267b4bf 
Tweak Detekt exception message
@rock3r
Shorten a title in README
f9b8f07
@rock3r
Remove "Kotlin" from a title in README
cb7a7d4
@rock3r
Note that excludes don't work for Detekt
21430dc
@rock3r
Note not to configure limits or failFast for Detekt
a38c70b
@rock3r
Explain how to exclude files from Detekt analysis
b6e2e1e
@rock3r
Tweak wording for adding Detekt to a project
fadaac3
@tasomaniac
Merge pull request #54 from novoda/add_detekt_and_reorganise_readme
0458a77 
Add Detekt docs and reorganise existing readme/docs
rock3r
rock3r approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@rock3r rock3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm shipping this since everything on this feature branch has been reviewed already

@rock3r rock3r merged commit 986bae9 into develop Jan 31, 2018
@rock3r rock3r deleted the PT-491/integrate_detekt branch January 31, 2018 15:24
@tobiasheine tobiasheine mentioned this pull request Feb 1, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rock3r rock3r rock3r approved these changes

@tasomaniac tasomaniac Awaiting requested review from tasomaniac

@mr-archano mr-archano Awaiting requested review from mr-archano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobiasheine @rock3r @tasomaniac @mr-archano