This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Tweak Detekt missing exception message #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
approved these changes
Jan 30, 2018
mr-archano
previously requested changes
Jan 30, 2018
| @@ -11,7 +11,7 @@ import org.gradle.api.Task | |||
| class DetektConfigurator implements Configurator { | |||
|
|
|||
| private static final String DETEKT_PLUGIN = 'io.gitlab.arturbosch.detekt' | |||
| private static final String DETEKT_NOT_APPLIED = 'The detekt plugin is configured but not applied. Please apply the plugin in your build script For more information see https://github.com/arturbosch/detekt.' | |||
| private static final String DETEKT_NOT_APPLIED = 'The detekt plugin is configured but not applied. Please apply the plugin in your build script.\nFor more informations see https://github.com/arturbosch/detekt.' | |||
There was a problem hiding this comment.
pretty sure information doesn't need that s as it's considered uncountable 😅 It would be good to ask some English speaker tho 🇬🇧 🇺🇸 🇨🇦
There was a problem hiding this comment.
Looks like you're right, will tweak in the morning :)
|
@tasomaniac there was a Oh well I'll have to open a new PR. |
|
@rock3r sorry about that :) Didn't see it. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the Detekt missing error message. Just adding a missing full stop and a new line for readability.