Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Tweak Detekt missing exception message #53

Merged
merged 3 commits into from
Jan 31, 2018
Merged

Tweak Detekt missing exception message #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40cba31
Tweak Detekt missing exception message
rock3r Jan 30, 2018
4696307
Update Missing Detekt message in tests
rock3r Jan 30, 2018
9cc5780
Fix typo
tasomaniac Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/src/main/groovy/com/novoda/staticanalysis/internal/detekt/DetektConfigurator.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import org.gradle.api.Task
class DetektConfigurator implements Configurator {

private static final String DETEKT_PLUGIN = 'io.gitlab.arturbosch.detekt'
private static final String DETEKT_NOT_APPLIED = 'The detekt plugin is configured but not applied. Please apply the plugin in your build script For more information see https://github.com/arturbosch/detekt.'
private static final String DETEKT_NOT_APPLIED = 'The detekt plugin is configured but not applied. Please apply the plugin in your build script.\nFor more information see https://github.com/arturbosch/detekt.'

private final Project project
private final Violations violations
Expand Down
4 changes: 3 additions & 1 deletion plugin/src/test/groovy/com/novoda/test/LogsSubject.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@ import javax.annotation.Nullable
import static com.novoda.test.TestProject.Result.Logs;

class LogsSubject extends Subject<LogsSubject, Logs> {

private static final String VIOLATIONS_LIMIT_EXCEEDED = "Violations limit exceeded"
private static final String DETEKT_NOT_APPLIED = "The detekt plugin is configured but not applied. Please apply the plugin in your build script For more information see https://github.com/arturbosch/detekt."
private static final String DETEKT_NOT_APPLIED = "The detekt plugin is configured but not applied. Please apply the plugin in your build script.\nFor more informations see https://github.com/arturbosch/detekt."
private static final String CHECKSTYLE_VIOLATIONS_FOUND = "Checkstyle violations found"
private static final String PMD_VIOLATIONS_FOUND = "PMD violations found"
private static final String FINDBUGS_VIOLATIONS_FOUND = "Findbugs violations found"
private static final String DETEKT_VIOLATIONS_FOUND = "Detekt violations found"

private static final SubjectFactory<LogsSubject, Logs> FACTORY = new SubjectFactory<LogsSubject, Logs>() {
@Override
LogsSubject getSubject(FailureStrategy failureStrategy, Logs logs) {
Expand Down