Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

[PT-491]: Integrate Detekt #58

Merged
merged 89 commits into from Jan 31, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
ee20ebf
Add TestKotlinProject to setup a test kotlin project
tobiasheine Jan 22, 2018
26b52d4
Support multiple plugins for test projects
tobiasheine Jan 22, 2018
1aa8d83
Add detekt kotlin fixtures
tobiasheine Jan 22, 2018
6bb5a1f
Expose kotlin test project rule
tobiasheine Jan 22, 2018
9d7b9d1
Add kotlin support to TestKotlinProject
tobiasheine Jan 22, 2018
3c03ba4
Expose projectDir to configure an output dir for detekt used in the t…
tobiasheine Jan 22, 2018
a87451e
Add DetektIntegrationTest which verifies the build fails when detekt …
tobiasheine Jan 22, 2018
54f982b
Simplify Warning Fixture
tobiasheine Jan 22, 2018
e1d1512
Add skeleton for DetektConfigurator
tobiasheine Jan 22, 2018
44c2b08
Add detekt to test project classpath
tobiasheine Jan 22, 2018
913a6e7
Apply detekt plugin in case the project has kotlin configured
tobiasheine Jan 22, 2018
5b775fe
Apply detekt configuration to the detekt extension
tobiasheine Jan 22, 2018
432bc1f
Fix broken Fixture path
tobiasheine Jan 23, 2018
b00ed49
Add empty line to fixture file in order to suppress not wanted detekt…
tobiasheine Jan 23, 2018
3903089
Add CollectDetektViolationsTask
tobiasheine Jan 23, 2018
fdd3756
Configure detekt task to collect violations
tobiasheine Jan 23, 2018
f5c85ca
Revert Fixture path change
tobiasheine Jan 23, 2018
c61e8e2
Link detekt report file to CollectDetektViolationsTask
tobiasheine Jan 23, 2018
c9af099
Remove not needed public keyword
tobiasheine Jan 23, 2018
eea5b69
Extract common Configurator interface
tobiasheine Jan 23, 2018
0bc714d
Create DetektConfigurator as part of other Configurators
tobiasheine Jan 23, 2018
9b4cf95
Add a test case to verify the the build fails when detekt errors are …
tobiasheine Jan 23, 2018
1b2a154
Verify the build does not fail in case detekt is not configured or th…
tobiasheine Jan 23, 2018
5b52771
Should not fail when no warnings or errors threshold trespassed
tobiasheine Jan 23, 2018
9249690
Remove empty line
tobiasheine Jan 23, 2018
faee71d
Rename field
tobiasheine Jan 23, 2018
7a82512
Rename class
tobiasheine Jan 23, 2018
4030061
Simplify task access
tobiasheine Jan 23, 2018
64405bb
Fix wrong generic type
tobiasheine Jan 23, 2018
70b7b2f
Add comment which might be useful for other developers
tobiasheine Jan 23, 2018
fd34d6b
Improve test names
tobiasheine Jan 24, 2018
584c716
Remove extra white line
tobiasheine Jan 24, 2018
794b74c
Fix format
tobiasheine Jan 24, 2018
0f87c44
Merge pull request #46 from novoda/PT-494/support_plain_kotlin_projects
tasomaniac Jan 24, 2018
c0f6eba
Support versions for adding a plugin
tobiasheine Jan 25, 2018
c573067
Do not apply detekt for each kotlin test project
tobiasheine Jan 25, 2018
0402b1a
Apply detekt plugin manually in tests
tobiasheine Jan 25, 2018
c27b3af
Do not apply detekt as part of our plugin since we expect the user to…
tobiasheine Jan 25, 2018
1b6b9c6
Add a test which verifies we inform the user to manually apply detekt…
tobiasheine Jan 25, 2018
b2e0a09
Throw an exception in case the detekt plugin is configured but not ap…
tobiasheine Jan 25, 2018
81a87eb
Fix typo
tobiasheine Jan 25, 2018
d9b1812
Use default parameter instead of passing null
tobiasheine Jan 25, 2018
d45e5a3
Check for the plugin rather than for a task
tobiasheine Jan 25, 2018
8ba85d1
Inline method
tobiasheine Jan 25, 2018
2ecbc1a
Extract detektConfiguration to improve test readability
tobiasheine Jan 25, 2018
8cd6c1b
Extract configuration to improve readability
tobiasheine Jan 25, 2018
71b32c5
Refer to detekt dokumentation on how to apply the plugin
tobiasheine Jan 25, 2018
e708ab5
Merge pull request #47 from novoda/PT-498/expect_the_user_to_configur…
tasomaniac Jan 25, 2018
4292d6b
Create TestAndroidKotlin project which can be used to verify the dete…
tobiasheine Jan 25, 2018
0f36aa9
Verify all tests are working as well for a android project using kotlin
tobiasheine Jan 25, 2018
a8a3f52
Name the source set folder to kotklin since it's a kotlin project
tobiasheine Jan 25, 2018
f717db0
Change label for android kotlin test project
tobiasheine Jan 26, 2018
72bd9fa
Remove nasty whitespaces
tobiasheine Jan 26, 2018
3eed973
Merge pull request #48 from novoda/PT-495/support_android_kotlin_proj…
tasomaniac Jan 26, 2018
0d734d0
Use relative path with project dir to link detekt reports
tobiasheine Jan 26, 2018
4eb544e
Make htmlReportFile configurable since detekt names it different than…
tobiasheine Jan 26, 2018
9e7061a
Link to correct detekt html report
tobiasheine Jan 26, 2018
318fb79
Use getter since we now have a field for the htmlReportFile
tobiasheine Jan 26, 2018
1277aef
Merge pull request #49 from novoda/PT-503/detekt_reports_are_not_pick…
tasomaniac Jan 26, 2018
3e91310
Improve readme file
rock3r Jan 29, 2018
d453d9c
Fix Apache 2.0 licence
rock3r Jan 30, 2018
21d3533
Move non-essential content out of the readme
rock3r Jan 30, 2018
8cf0a9e
Clarify supported tools table in README
rock3r Jan 30, 2018
dfc590a
Reorganise advanced-usage contents
rock3r Jan 30, 2018
8930952
Add TOC to advanced-usage
rock3r Jan 30, 2018
691c20d
Create supported-tools
rock3r Jan 30, 2018
accf4fc
Simplify README, point to pages in docs/
rock3r Jan 30, 2018
7c43d55
Add missing whiteline at EOF in NOTICE
rock3r Jan 30, 2018
d4c6ef0
Fix Android Lint support matrix
rock3r Jan 30, 2018
ce97e86
Add documentation for the Checkstyle plugin
rock3r Jan 30, 2018
1b32738
Add instructions for enabling/disabling tools
rock3r Jan 30, 2018
e0e5ff4
Use defaults in config in the README file
rock3r Jan 30, 2018
40cba31
Tweak Detekt missing exception message
rock3r Jan 30, 2018
4696307
Update Missing Detekt message in tests
rock3r Jan 30, 2018
0577d74
Add documentation for all tools to supported-tools
rock3r Jan 30, 2018
9cc5780
Fix typo
tasomaniac Jan 31, 2018
4160752
Merge pull request #53 from novoda/tweak-detekt-exception-message
tasomaniac Jan 31, 2018
f7074d1
Merge branch 'PT-491/integrate_detekt' into add_detekt_and_reorganise…
rock3r Jan 31, 2018
fb10e7f
Fix grammar in error message
rock3r Jan 31, 2018
f0d2803
Cleanup DetektConfigurator
rock3r Jan 31, 2018
2a02420
Cleanup LogsSubject
rock3r Jan 31, 2018
267b4bf
Merge pull request #57 from novoda/tweak-detekt-exception-message
mr-archano Jan 31, 2018
f9b8f07
Shorten a title in README
rock3r Jan 31, 2018
cb7a7d4
Remove "Kotlin" from a title in README
rock3r Jan 31, 2018
21430dc
Note that excludes don't work for Detekt
rock3r Jan 31, 2018
a38c70b
Note not to configure limits or failFast for Detekt
rock3r Jan 31, 2018
b6e2e1e
Explain how to exclude files from Detekt analysis
rock3r Jan 31, 2018
fadaac3
Tweak wording for adding Detekt to a project
rock3r Jan 31, 2018
0458a77
Merge pull request #54 from novoda/add_detekt_and_reorganise_readme
tasomaniac Jan 31, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
177 changes: 177 additions & 0 deletions LICENSE
@@ -0,0 +1,177 @@

Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS