Fix ConnectivityReceiver tests #69

ataulm · 2015-10-07T15:14:34Z

Fixes ConnectivityReceiverShould#notifyTheMerlinServiceOnValidConnectivityIntents:

Wanted but not invoked:
merlinService.onConnectivityChanged(<any>);
-> at com.novoda.merlin.receiver.ConnectivityReceiverShould.notifyTheMerlinServiceOnValidConnectivityIntents(ConnectivityReceiverShould.java:65)
Actually, there were zero interactions with this mock.

- this is intended to show no interaction with merlin service - it does this, but for the wrong reason (intent == null)

ataulm · 2015-10-07T15:17:58Z

core/src/test/java/com/novoda/merlin/receiver/ConnectivityReceiverShould.java

@@ -57,10 +64,10 @@ public void notNotifyTheMerlinServiceOnNonConnectivityIntents() throws Exception

    @Test
    public void notifyTheMerlinServiceOnValidConnectivityIntents() throws Exception {
-        Intent intent = new Intent();
-        intent.setAction(ConnectivityManager.CONNECTIVITY_ACTION);
+        Intent mock = mock(Intent.class);


I think this is a valid candidate for mocking - both the context and the intent are being called from outside of our system (outside of our class)

ouchadam · 2015-10-08T09:37:55Z

core/src/test/java/com/novoda/merlin/receiver/ConnectivityReceiverShould.java


        verifyZeroInteractions(merlinService);
    }

    @Test
    public void notifyTheMerlinServiceOnValidConnectivityIntents() throws Exception {
-        Intent intent = new Intent();


really confused as to how this was null?

ouchadam · 2015-10-08T10:06:44Z

not a blocker for me

Fix ConnectivityReceiver tests

ataulm added 2 commits October 7, 2015 17:12

Fix ConnectivityReceiver tests

bef2f04

Correctify the other intent based test

0660f1f

- this is intended to show no interaction with merlin service - it does this, but for the wrong reason (intent == null)

ataulm reviewed Oct 7, 2015
View reviewed changes

ataulm assigned ouchadam Oct 7, 2015

ouchadam reviewed Oct 8, 2015
View reviewed changes

ouchadam added a commit that referenced this pull request Oct 8, 2015

Merge pull request #69 from novoda/fix_connectivity_receiver_test

50b37a8

Fix ConnectivityReceiver tests

ouchadam merged commit 50b37a8 into migrate-to-android-unit-test Oct 8, 2015

ouchadam deleted the fix_connectivity_receiver_test branch October 8, 2015 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ConnectivityReceiver tests #69

Fix ConnectivityReceiver tests #69

ataulm commented Oct 7, 2015

ataulm Oct 7, 2015

ouchadam Oct 8, 2015

ouchadam commented Oct 8, 2015

Fix ConnectivityReceiver tests #69

Fix ConnectivityReceiver tests #69

Conversation

ataulm commented Oct 7, 2015

ataulm Oct 7, 2015

Choose a reason for hiding this comment

ouchadam Oct 8, 2015

Choose a reason for hiding this comment

ouchadam commented Oct 8, 2015