Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Update CI release job once master in sync with develop #159

Closed
mr-archano opened this issue May 28, 2018 · 2 comments
Closed

Update CI release job once master in sync with develop #159

mr-archano opened this issue May 28, 2018 · 2 comments

Comments

@mr-archano
Copy link
Contributor

Problem

We have recently added the support for snapshot releases as part of #152, but we are missing that code in master. Next time we want to promote the current develop to be part of an official release the CI job (https://ci.novoda.com/job/no-player/) might fail as the release config has changed.

Potential Solution

Ideally we would change the CI job to use the secret properties file (already provided here) similar to what already done for the snapshot job.

Impact

Fixing the issue will allow us to correctly release a new version of the player without issues, and if follow the suggestion above we can start adopting the secrets files to avoid hidden credentials setup and promote explicit setup as part of the build scripts.

@Mecharyry
Copy link
Contributor

@mr-archano I've updated the main job to use the secret properties file. Is it ok for us to close this issue now?

@mr-archano
Copy link
Contributor Author

Yep, I think so: you must have addressed this before being able to release from master 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants