This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Support snapshot releases from develop
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
reviewed
May 10, 2018
core/build.gradle
Outdated
| ['bintrayRepo': 'n/a', 'bintrayUser': 'n/a', 'bintrayKey': 'n/a'] : | ||
| new File("${System.getenv('BINTRAY_PROPERTIES')}") | ||
| } | ||
| using(cli).or(bintrayCredentials()) |
ouchadam
reviewed
May 10, 2018
core/build.gradle
Outdated
| publish { | ||
| def generateVersion = { | ||
| boolean isSnapshot = cli['bintraySnapshot'].or(false).boolean | ||
| return isSnapshot ? System.getenv('GIT_COMMIT')?:'SNAPSHOT' : version |
There was a problem hiding this comment.
git commit or jenkins build number?
I'm leaning towards build number as it's easier to communicate
There was a problem hiding this comment.
yeah, I had no idea tbh :D
we can pick other values too, but I am happy to go for BUILD_NUMBER
|
small question around the variable to build the version out of, otherwise looking great! 💯 |
|
|
|
good point about the badges. |
|
@Mecharyry I started there, but then it looked ugly, and decided for the additional section. we can add those badges in there if you prefer? (the link in there is already pointing to the last snapshot) |
ouchadam
approved these changes
May 11, 2018
Mecharyry
approved these changes
May 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we work on a new feature or a bug fix we would like to be able to use a new snapshot of the library without releasing to JCenter.
Solution
We have decided to use a new Bintray repo (https://bintray.com/novoda/snapshots) where to push such builds. This PR adds the necessary Gradle setup that allows us to define whether a certain build on the CI needs to land to the snapshots repo or not.
A new CI job has been configured:
developchanges (ie: after a feature branch is merged)Test(s) added
It's all Gradle stuff, so no automated test. I had to check manually whether the inputs were correctly handled in the build script.
Screenshots
No UI changes, therefore no screenshots.
Paired with
Nobody