This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updates tests to match facade usage
Exoplayer2/ AndroidMediaPlayerFacade tests
…ate implementation detail of loading content
…urface holder requester
… the player instead
…hen calling from release
Exoplayer2/ AndroidMediaPlayerAudioTrackSelector tests
matches the media player
…no-player into exoplayer2-reset
…nd into the mediaplayer impl, matching the exoplayer
…ich require the player to be attached
…ferred by being a type reader
Hiding `PlayerChecker`
ALL-3936/Leaking Player through error listeners
ALL-3936/Error classes
…is internally managing the surfaceview state
…ayerview from the player
… attached to it when attach a playerview
Delegate SurfaceHolder lifecycle to ExoPlayer
… have both a player and play view
Decouple error messaging
Exoplayer SurfaceHolder lifecycle
🎉 👍 Let's do it |
ataulm
approved these changes
Jul 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Upgrades to ExoPlayer2 and redesigns the public Api
Notable api changes
Players
are created viaPlayerBuilder
instead ofPlayerFactory
Player.getListeners().add...
instead ofPlayer.add...
Player.reset
is removed in favour ofPlayer.stop
Implementations
#17 Barebones ExoPlayer2 migration (without drm/subtitles)
#21 Refactoring exoplayer facade listeners
#23 Refactoring exoplayer forwarders
#24 Refactoring media player listens
#25 Adding audio tracks to exoplayer
#26 Avoid leaking exoplayer classes to public api
#27
ExoplayerImpl
andExoPlayerAudioTrackSelector
unit tests#29 Demo audio track selection
#30 Adds ListenerHolder collaborator
#33 MediaPlayer facade tests
#37 AndroidMediaSelector tests
#38 Mediaplayer facade refactor/tests
#39 Consistent reset logic
#41 MediaPlayer state exceptions
#42 Reducing listeners scope
#43 MediaPlayerImpl creation refactoring
#44 decouple exoplayer constructor listeners
#45 Removing notils
#47 Readding subtitles
#48 Widevine modular streaming support
#50 Widevine modular download support
#51 Drm error propagation
#52 Exposing non secure decoder usage as client api
#54 Asserting Drm is supported when attempting to use drm
#55 Package restructuring
#56 Wrapping exoplayer TextCues to avoid leaking
#57 Replacing
PlayerFactory
withPlayerBuilder
#58 Javadoc supported public api
#59 Introducing
internal
package for all non support public classes#61 Fixing NPE in subitles
#62 No longer exposing
PlayerChecker
in favour of more information onPlayerInformation
#63 Removing leaking Player from error listeners
#64 Removing Typed player errors and instead providing a ErrorType
#65 Delegating SurfaceHolder lifecycle to exoplayer
#66 Decouple error messages
#67 Fixing exoplayer surfaceholder usage
Test(s) added
Yes lots !
Paired with
@juankysoriano @Dorvaryn @jackSzm @zegnus