This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
ALL-3936/Error classes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zegnus
reviewed
Jun 30, 2017
|
|
||
| public class NoPlayerError implements Player.PlayerError { | ||
|
|
||
| private final PlayerErrorType playerErrorType; |
ataulm
reviewed
Jun 30, 2017
| FAILED_DRM_INITIATING, | ||
| FAILED_DRM_REQUEST, | ||
| CONNECTIVITY_ERROR, | ||
| MEDIA_FORMAT_NOT_RECOGNISED, |
ataulm
reviewed
Jun 30, 2017
| MEDIA_SERVER_DIED, | ||
| MEDIA_SOURCE_ERROR, | ||
| STREAMED_VIDEO_ERROR, | ||
| UNKNOWN |
There was a problem hiding this comment.
@Dorvaryn disappointed to not find UNKOWN
ataulm
suggested changes
Jun 30, 2017
ataulm
approved these changes
Jun 30, 2017
zegnus
approved these changes
Jun 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are exposing the internals of
no-playerthrough ourPlayer.PlayerErrorimplementations that reference directly media-player or exo-player.Solution
Remove the specific implementations in favour of an
PlayerErrorTypethat lives on thePlayer.PlayerError. We need to make these types more generic to apply acrossPlayerboundaries. This is the first step to remove the class implementations for the type.Test(s) added
No, just swapping out the implementations for a generic exception.
Screenshots
No UI changes.
Paired with
@Dorvaryn