Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Exponential Retry Mechanism with Idempotency Headers #62

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Add Exponential Retry Mechanism with Idempotency Headers #62

merged 1 commit into from
Oct 8, 2023

Conversation

mahendraHegde
Copy link
Contributor

@mahendraHegde mahendraHegde commented Oct 7, 2023 •
edited

closes #59

This PR

  • Adds HTTP Exponential Retry mechanism to novu client
  • Adds relevant tests
  • Adds UUID based Idempotency Headers
  • Updates Docs

    Sample usage
	novuClient := novu.NewAPIClient(apiKey, &novu.Config{RetryConfig: &novu.RetryConfigType{RetryMax: 3, WaitMin: 1 * time.Second, WaitMax: 5 * time.Second, InitialDelay: 0 * time.Second}})

This was referenced Oct 8, 2023
Merged
Closed
Cliftonz
Cliftonz approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@Cliftonz Cliftonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Work on this!

@Cliftonz Cliftonz merged commit 9a5def3 into novuhq:master Oct 8, 2023
1 check passed
This was referenced Oct 8, 2023
Open
Open
Open
Closed
Closed
Open
Open
Open
@mahendraHegde
Copy link
Contributor Author

Amazing Work on this!

thanks @Cliftonz, i'd be happy to work on server side implementation of Idempotency as well.

@Cliftonz
Copy link
Contributor

Cliftonz commented Oct 8, 2023

@mahendraHegde Cool, message me in discord privately and lets go from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cliftonz Cliftonz Cliftonz approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Exponential Retry Mechanism with Idempotency Headers
3 participants
@mahendraHegde @Cliftonz @unicodeveloper