-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic operations on notification templates #30
Conversation
Implemented: - List all templates - Get template by id - Delete template - Update template status
…Templates` folder
@unicodeveloper I fixed your remarks, hope it's more readable now |
Yes, this is good! |
Think we can merge it if no other comments. @wh1337 said before that failing tests are ok for now, bc it's a ci problem |
Can you attach a screenshot of passing tests locally whilst we fix the CI issue? |
LGTM ⭐ |
Please update the readme @Badabum |
Sure, will do |
Just got back into the office and reviewing this will be reviewed and merged tonight @Badabum |
Review the comment I put on the review, once resolved we can rebase it on to main. |
Thanks @wh1337 please this has to go in today. 🙏🏿 |
Implemented: