Added basic operations on notification templates #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented: - List all templates - Get template by id - Delete template - Update template status
5 tasks
…Templates` folder
|
@unicodeveloper I fixed your remarks, hope it's more readable now |
Yes, this is good! |
|
Think we can merge it if no other comments. @wh1337 said before that failing tests are ok for now, bc it's a ci problem |
|
Can you attach a screenshot of passing tests locally whilst we fix the CI issue? |
|
|
LGTM ⭐ |
unicodeveloper
approved these changes
May 21, 2023
|
Please update the readme @Badabum |
Sure, will do |
|
Just got back into the office and reviewing this will be reviewed and merged tonight @Badabum |
wh1337
reviewed
May 25, 2023
|
Review the comment I put on the review, once resolved we can rebase it on to main. |
|
Thanks @wh1337 please this has to go in today. 🙏🏿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented: