Merge pull request #66 from therealansh/patch-1

fix: bulk api response type
novuhq · Feb 20, 2024 · 80969d7 · 80969d7
2 parents 259d728 + 744b899
commit 80969d7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/src/main/kotlin/api/EventsApi.kt b/src/main/kotlin/api/EventsApi.kt
@@ -21,7 +21,7 @@ interface EventsApi {
     suspend fun triggerEvent(@Body body: TriggerEventRequest): Response<ResponseWrapper<TriggerResponse>>
 
     @POST("$ENDPOINT/trigger/bulk")
-    suspend fun bulkTriggerEvent(@Body body: BulkTriggerEventRequest): Response<ResponseWrapper<TriggerResponse>>
+    suspend fun bulkTriggerEvent(@Body body: BulkTriggerEventRequest): Response<ResponseWrapper<List<TriggerResponse>>>
 
     @POST("$ENDPOINT/trigger/broadcast")
     suspend fun broadcastEvent(@Body body: BroadcastEventRequest): Response<ResponseWrapper<TriggerResponse>>

diff --git a/src/main/kotlin/extensions/EventsExtensions.kt b/src/main/kotlin/extensions/EventsExtensions.kt
@@ -16,7 +16,7 @@ suspend fun Novu.trigger(body: TriggerEventRequest): ResponseWrapper<TriggerResp
     return response.extractResponse(logger)
 }
 
-suspend fun Novu.bulkTrigger(body: BulkTriggerEventRequest): ResponseWrapper<TriggerResponse>? {
+suspend fun Novu.bulkTrigger(body: BulkTriggerEventRequest): ResponseWrapper<List<TriggerResponse>>? {
     val response = eventsApi.bulkTriggerEvent(body)
     return response.extractResponse(logger)
 }

diff --git a/src/test/kotlin/EventsApiTest.kt b/src/test/kotlin/EventsApiTest.kt
@@ -97,11 +97,13 @@ class EventsApiTest {
     @Test
     fun testBulkTriggerEvent() = runTest {
         val responseBody = ResponseWrapper(
-            TriggerResponse(
-                acknowledged = true,
-                status = "status",
-                transactionId = "transactionId",
-                error = listOf("error")
+            listOf(
+                TriggerResponse(
+                    acknowledged = true,
+                    status = "status",
+                    transactionId = "transactionId",
+                    error = listOf("error")
+                )
             )
         )
         mockWebServer.enqueue(