fix: bulk api response type #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bulk Trigger returns list of trigger response
|
@unicodeveloper @Cliftonz review please^ |
|
@mayorJAY please review |
mayorJAY
reviewed
Feb 13, 2024
| @@ -21,7 +21,7 @@ interface EventsApi { | |||
| suspend fun triggerEvent(@Body body: TriggerEventRequest): Response<ResponseWrapper<TriggerResponse>> | |||
|
|
|||
| @POST("$ENDPOINT/trigger/bulk") | |||
| suspend fun bulkTriggerEvent(@Body body: BulkTriggerEventRequest): Response<ResponseWrapper<TriggerResponse>> | |||
| suspend fun bulkTriggerEvent(@Body body: BulkTriggerEventRequest): Response<ResponseWrapper<List<TriggerResponse>>> | |||
There was a problem hiding this comment.
Looks good but you need to modify the unit test based on your changes
There was a problem hiding this comment.
|
Folks can we merge this and take this live asap i see there are few more commits which are not live yet? |
Cliftonz
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk Trigger returns list of trigger response