Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bulk api response type #66

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Conversation

therealansh
Copy link
Contributor

Bulk Trigger returns list of trigger response

Bulk Trigger returns list of trigger response
@therealansh
Copy link
Contributor Author

@unicodeveloper @Cliftonz review please^

@unicodeveloper
Copy link
Contributor

@mayorJAY please review

@@ -21,7 +21,7 @@ interface EventsApi {
suspend fun triggerEvent(@Body body: TriggerEventRequest): Response<ResponseWrapper<TriggerResponse>>

@POST("$ENDPOINT/trigger/bulk")
suspend fun bulkTriggerEvent(@Body body: BulkTriggerEventRequest): Response<ResponseWrapper<TriggerResponse>>
suspend fun bulkTriggerEvent(@Body body: BulkTriggerEventRequest): Response<ResponseWrapper<List<TriggerResponse>>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you need to modify the unit test based on your changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@therealansh
Copy link
Contributor Author

Folks can we merge this and take this live asap i see there are few more commits which are not live yet?

@unicodeveloper unicodeveloper merged commit 80969d7 into novuhq:main Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants