Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some changes to the doc #1607

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Made some changes to the doc #1607

merged 3 commits into from
Oct 11, 2022

Conversation

Akash190104
Copy link
Contributor

@Akash190104 Akash190104 commented Oct 10, 2022

I noticed a few grammatical errors and felt that the document was a bit unclear at parts. Please look into this. Thank you for reading my pull request in Advance.

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Docs Update
  • Why was this change needed? (You can also link to an open issue here)
    To enhance the quality of the documentation.

I noticed a few grammatical errors and felt that the document was a bit unclear at parts. Please look into this. Thank you for reading my pull request in Advance.
@Akash190104 Akash190104 changed the title Made some lines a bit more clear Made some changes to the doc Oct 10, 2022
@Akash190104
Copy link
Contributor Author

@p-fernandez @scopsy Please review this.

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution! Really appreciate it 🙏

@scopsy
Copy link
Contributor

scopsy commented Oct 11, 2022

Do you mind resolving the conflicts here @Akash190104 ?

@Akash190104
Copy link
Contributor Author

@scopsy Please review this. I have resolved the conflict.

@scopsy scopsy merged commit 361e8d1 into novuhq:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants