Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment module #1928

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Add environment module #1928

merged 5 commits into from
Nov 2, 2022

Conversation

Wyfy0107
Copy link
Contributor

What kind of change does this PR introduce?

  • Bug
  • [x ] Feature
  • Docs
  • Other(s)

Why was this change needed?

fixes #1323
Node client needs to be able to create environment

Other information (Screenshots)

Copy link
Contributor

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! There is only a little change to make

Co-authored-by: Florian LEFEBVRE <contact@florian-lefebvre.dev>
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@p-fernandez p-fernandez merged commit 6c89efb into novuhq:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@novu/node: complete the environments module
3 participants