-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Abstracted content engine #2003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good abstraction. Besides a pair of comments you would also need to update the test file: https://github.com/novuhq/novu/blob/2d3050a13b5dfc77b0d66e34ed2eac8a25299631/packages/stateless/src/lib/content/content.engine.spec.ts
that is dependant in the changes you are proposing.
Didn't get to that just yet, but I will update the tests as well. Thanks for the review, I'll try and update the PR in the upcoming week 👍 |
5781876
to
ff32068
Compare
@p-fernandez to what extend, and especially in which files, should I test the ability to change the engine? Should I add tests to both the email and sms handler (spec)? I already updated the |
Not sure if I understood you correctly but I do not think you should test what happens if changing the engine (moving from Handlebars to a different library). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟
What change does this PR introduce?
Initial thoughts on how the content engine might be abstracted to allow it to be extended / replaced.
Why was this change needed?
Closes #2002
Other information (Screenshots)