Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(notification-center): api reference page #2631

Merged
merged 26 commits into from
Feb 2, 2023
Merged

docs(notification-center): api reference page #2631

merged 26 commits into from
Feb 2, 2023

Conversation

LetItRock
Copy link
Contributor

@LetItRock LetItRock commented Jan 27, 2023 •
edited

What change does this PR introduce?

The React notification-center package API reference page.

Why was this change needed?

Other information (Screenshots)

Screenshot 2023-01-27 at 13 14 40
Screenshot 2023-01-27 at 13 14 55

Screen.Recording.2023-01-27.at.13.26.05.mov

@LetItRock LetItRock self-assigned this Jan 27, 2023
@linear
Copy link

linear bot commented Jan 27, 2023

NV-1594 React Notification Center package API Reference page

Create the API reference page for the notification-center package in the docs.

@github-actions github-actions bot added @novu/notification-center documentation Improvements or additions to documentation labels Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

p-fernandez
p-fernandez previously approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few typos and some suggestions.
Very thorough documentation. Great work.

docs/docs/notification-center/react/api-reference.md Outdated Show resolved Hide resolved
docs/docs/notification-center/react/api-reference.md Outdated Show resolved Hide resolved
docs/docs/notification-center/react/api-reference.md Outdated Show resolved Hide resolved
docs/docs/notification-center/react/api-reference.md Outdated Show resolved Hide resolved
docs/docs/notification-center/react/api-reference.md Outdated Show resolved Hide resolved
docs/docs/notification-center/react/api-reference.md Outdated Show resolved Hide resolved
docs/docs/notification-center/react/api-reference.md Show resolved Hide resolved
docs/docs/notification-center/react/api-reference.md Outdated Show resolved Hide resolved
docs/docs/notification-center/react/react-components.md Outdated Show resolved Hide resolved
docs/docs/notification-center/react/react-components.md Outdated Show resolved Hide resolved
renovate bot and others added 19 commits January 31, 2023 11:34
@renovate
chore(deps): update dependency standard-version to v9.5.0
efc63ed
@renovate
chore(deps): update dependency tsconfig-paths to v3.14.1
a200d95
Merge pull request #2652 from novuhq/renovate/standard-version-9.x
2604508 
chore(deps): update dependency standard-version to v9.5.0
@p-fernandez
fix(infra): remove standard-version package as being unused
a8d38b1
Merge pull request #2659 from novuhq/fix-infra-unused-standard-version
cef623a 
fix(infra): remove standard-version package as being unused
@scopsy
Merge pull request #2655 from novuhq/renovate/tsconfig-paths-3.x
297c8ac 
chore(deps): update dependency tsconfig-paths to v3.14.1
@scopsy
Merge branch 'main' into next
220d4bf
@scopsy
Merge branch 'next' of https://github.com/novuhq/novu into next
46eb8de
@renovate
chore(deps): update dependency typedoc to ^0.23.0
453abd7
@scopsy
chore: update package versions
20d2cac
@scopsy
Update README.md
d1e5109
@scopsy
Merge pull request #2658 from novuhq/renovate/typedoc-0.x
4ae361d 
chore(deps): update dependency typedoc to ^0.23.0
@renovate
chore(deps): update dependency jira-prepare-commit-msg to v1.7.2
e15f716
@scopsy
Merge pull request #2663 from novuhq/renovate/jira-prepare-commit-msg…
72abf50 
…-1.x

chore(deps): update dependency jira-prepare-commit-msg to v1.7.2
@Cliftonz
Merge branch 'next' into cspell-update
586f70e 
# Conflicts:
#	pnpm-lock.yaml
@Cliftonz
fix(pnpm): fix merge conflicts
e23daf8
@renovate
chore(deps): update dependency webpack-dev-server to v4.11.1
a3fc684
@scopsy
Merge pull request #2613 from novuhq/cspell-update
8df930a 
chore(cspell): update cspell
@scopsy
Merge pull request #2664 from novuhq/renovate/webpack-dev-server-4.x
596bdcd 
chore(deps): update dependency webpack-dev-server to v4.11.1
@scopsy scopsy changed the base branch from next to main February 2, 2023 08:42
@scopsy scopsy dismissed p-fernandez’s stale review February 2, 2023 08:42

The base branch was changed.

@scopsy scopsy merged commit 029515e into main Feb 2, 2023
@scopsy scopsy deleted the nv-1594-notification-center-api-reference branch February 2, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopsy scopsy scopsy approved these changes

@p-fernandez p-fernandez p-fernandez left review comments

Assignees

@LetItRock LetItRock

Labels
documentation Improvements or additions to documentation @novu/api @novu/notification-center @novu/web providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LetItRock @scopsy @p-fernandez @Cliftonz