Polishing: Some design issues #2744 #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[NV-1657] ✨ Polishing: Some design issues in the Integration Store novuhq#2744
added padding between scroll bar and inputs
scopsy
reviewed
Feb 14, 2023
| @@ -1,4 +1,23 @@ | |||
| import { defineConfig } from 'cypress'; | |||
| const configOverride = require('./config-overrides'); | |||
There was a problem hiding this comment.
This was needed to make cypress work with babelrc
scopsy
reviewed
Feb 14, 2023
| @@ -311,6 +311,8 @@ describe('Creation functionality', function () { | |||
| cy.getByTestId('groupSelector').clear(); | |||
| cy.getByTestId('groupSelector').type('New Test Category'); | |||
| cy.getByTestId('submit-category-btn').click(); | |||
| cy.waitForNetworkIdle(500); | |||
There was a problem hiding this comment.
Flaky test here before, so hope it will help with it
scopsy
reviewed
Feb 14, 2023
| @@ -350,6 +350,7 @@ const InputWrapper = styled.div` | |||
| margin-bottom: 10px; | |||
| font-size: 14px; | |||
| } | |||
| padding-right: 30px; | |||
There was a problem hiding this comment.
@nikitagrossman why is the padding here needed?
If any, I would put it on the CenterDiv component instead of on the input wrapppers
There was a problem hiding this comment.
i did that so the scroll bar would not touch any inputs
anyway i changed that
fix: padding moved to centerDiv
|
Noice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NV-1657] ✨ Polishing: Some design issues in the Integration Store #2744
What change does this PR introduce?
minor design changes in integration store
buttons do not scroll when inside form + added padding so it looks much better & when u hover on a !active provider card the opacity comes up to 1
Why was this change needed?
better looking
closes #2744
closes #2388
Screen.Recording.2023-02-14.at.11.37.09.mov