Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-1657] ✨ Polishing: Some design issues in the Integration Store #2744

Closed
2 tasks done
SebastianStehle opened this issue Feb 12, 2023 · 5 comments · Fixed by #2759
Closed
2 tasks done

[NV-1657] ✨ Polishing: Some design issues in the Integration Store #2744

SebastianStehle opened this issue Feb 12, 2023 · 5 comments · Fixed by #2759
Assignees
Labels
linear polishing Created by Linear-GitHub Sync

Comments

@SebastianStehle
Copy link

SebastianStehle commented Feb 12, 2023

📜 Description

  1. Scrollbars:

image

  • Close button should not scroll
  • Inner content should have a padding.
  • IMHO: Update should not scroll either.
  1. Hovering an integration

image

  • Makes the "starting provider blurry" (it is already hard to read)
  • Reduces the contrast of the text and makes it actually harder to read, not better. I think a hover or focus style should improve readability, not make it worse.

👟 Reproduction steps

No response

👍 Expected behavior

No response

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

NV-1657

@SebastianStehle SebastianStehle added the polishing Created by Linear-GitHub Sync label Feb 12, 2023
@scopsy scopsy changed the title ✨ Polishing: Some design issues in the Integration Store [NV-1657] ✨ Polishing: Some design issues in the Integration Store Feb 12, 2023
@scopsy
Copy link
Contributor

scopsy commented Feb 12, 2023

I believe the first item also connected to: #2388 just linking it here

@nikitagrossman
Copy link
Contributor

i would like to help with that

@oba2311
Copy link
Contributor

oba2311 commented Feb 12, 2023

Thanks so much OP!

@skooby why don't you give it a shot? Do you have time to work on it this week?

@nikitagrossman
Copy link
Contributor

yeah ofc (:

@aayushdura
Copy link
Contributor

aayushdura commented Feb 14, 2023

@nikitagrossman @scopsy
Right now there is custom close button rendering inside the Integration Form, but instead we can provide withCloseButton to the modal itself for close button which is fixed at modal header,
Similarly, We can use the header props to supply react node as header for rendering Names of Emailing Platform alongside the close button.
/apps/web/src/pages/integrations/IntegrationsStorePage.tsx

nikitagrossman added a commit to nikitagrossman/novu that referenced this issue Feb 14, 2023
[NV-1657] ✨ Polishing: Some design issues in the Integration Store novuhq#2744
scopsy added a commit that referenced this issue Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear polishing Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants