fix: Update Subscribers API allowing null

[jayavardhan3112]

What change does this PR introduce?

Changed the update subscriber API, thus when there is a null or empty string, it will unset the email from the database

Why was this change needed?

Closes #3022

[scopsy]

Because currently the endpoint behaving like a partial update endpoint with all fields this can lead to situation where the email is removed when updating other fields. Can we maybe perform a check like it was previously, but instead of != null we can check for !== undefined so in case null was passed, we will update the field to null instead of unsettling it. wdyt?

[jayavardhan3112]

Because currently the endpoint behaving like a partial update endpoint with all fields this can lead to situation where the email is removed when updating other fields. Can we maybe perform a check like it was previously, but instead of != null we can check for !== undefined so in case null was passed, we will update the field to null instead of unsettling it. wdyt?

So when a user passes an empty string on Null, then only the email would be unset, (The reason I unset the Email Key is what if its empty string , or Null, this would make the code to add redundant checks), thus I thought of unsetting the key,

[scopsy]

@jayavardhan3112 yes exactly, when it's undefined it should be untouched. I think setting it as null can help make queries for those users vs unset (meaning it was never set) similar to the semantic undefined vs null situation. Wdyt?

[jayavardhan3112]

@jayavardhan3112 yes exactly, when it's undefined it should be untouched. I think setting it as null can help make queries for those users vs unset (meaning it was never set) similar to the semantic undefined vs null situation. Wdyt?

makes sense, I will update this and let you know, Thnx

[jayavardhan3112]

Updated, Please Review

[p-fernandez]

🌟
@jayavardhan3112 please solve the conflicts so we can merge it. Sorry it took us so long. 🙏🏻

[jayavardhan3112]

Updated, @p-fernandez . am not able to resolve them, could you please check the access

[p-fernandez]

@jayavardhan3112 could you give me write permissions in your repository to push the conflict fix in your next branch? The PR was closed because I could only push Novu's next branch so the PR gets invalidated.
By the way don't worry as I have your PR fixed in a branch in my repository.

[jayavardhan3112]

@jayavardhan3112 could you give me write permissions in your repository to push the conflict fix in your next branch? The PR was closed because I could only push Novu's next branch so the PR gets invalidated.
By the way don't worry as I have your PR fixed in a branch in my repository.

Hi @p-fernandez , Have invited you to collaborate to the PR

[p-fernandez]

@jayavardhan3112 done. Can you do a quick review and confirm all your changes are there?

[jayavardhan3112]

@jayavardhan3112 done. Can you do a quick review and confirm all your changes are there?

Looks good to me, you can go ahead and merge it, Thank you