Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suscriber response dto #3276

Merged
merged 5 commits into from
Apr 25, 2023
Merged

fix: suscriber response dto #3276

merged 5 commits into from
Apr 25, 2023

Conversation

jainpawan21
Copy link
Member

What change does this PR introduce?

fix few dtos issue

Why was this change needed?

Other information (Screenshots)

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, do you think we should update the
subscribers/:subscriberId/notifications/feed endpoint in this PR as well?

In addition, what do you think about a small test that checks if the limit from the query will work?

@@ -20,7 +20,7 @@ export class InboundParseController {
summary: 'Validate the mx record setup for the inbound parse functionality',
})
@ApiOkResponse({
type: [GetMxRecordResponseDto],
type: GetMxRecordResponseDto,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jainpawan21
Copy link
Member Author

Looks good to me, do you think we should update the subscribers/:subscriberId/notifications/feed endpoint in this PR as well?

In addition, what do you think about a small test that checks if the limit from the query will work?

Fixed this endpoint also

@jainpawan21 jainpawan21 added this pull request to the merge queue Apr 25, 2023
Merged via the queue into next with commit 001ebe4 Apr 25, 2023
@jainpawan21 jainpawan21 deleted the fix/subscriber-response-dto branch April 25, 2023 13:58
@marceln
Copy link

marceln commented Apr 25, 2023

@jainpawan21 any idea how long until we can see these changes in the OAS spec at https://api.novu.co/api-json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants