-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: suscriber response dto #3276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, do you think we should update the
subscribers/:subscriberId/notifications/feed
endpoint in this PR as well?
In addition, what do you think about a small test that checks if the limit from the query will work?
@@ -20,7 +20,7 @@ export class InboundParseController { | |||
summary: 'Validate the mx record setup for the inbound parse functionality', | |||
}) | |||
@ApiOkResponse({ | |||
type: [GetMxRecordResponseDto], | |||
type: GetMxRecordResponseDto, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Fixed this endpoint also |
@jainpawan21 any idea how long until we can see these changes in the OAS spec at https://api.novu.co/api-json? |
What change does this PR introduce?
fix few dtos issue
Why was this change needed?
Other information (Screenshots)