chore(application-generic): moved the timed digest delay calculations #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the main repo
NV-2318 Move the timed digest delay calculations to the application-generic
Why? (Context)This is the decision we take because we have some problems checking out the submodules (with GitHub Desktop). What?Definition of Done |
davidsoderberg
approved these changes
May 15, 2023
p-fernandez
approved these changes
May 15, 2023
| [OrdinalValueEnum.SUNDAY]: RRule.SU, | ||
| }; | ||
|
|
||
| const ORDINAL_TO_RRULE_BYMONTHDAY = { |
There was a problem hiding this comment.
Suggested change
| const ORDINAL_TO_RRULE_BYMONTHDAY = { | |
| const ORDINAL_TO_RRULE_BY_MONTH_DAY = { |
Thus we also avoid spellcheck warning.
packages/application-generic/src/services/calculate-delay/timed-digest-delay.service.ts
Outdated
Show resolved
Hide resolved
packages/application-generic/src/services/calculate-delay/timed-digest-delay.service.ts
Outdated
Show resolved
Hide resolved
| addWeeks, | ||
| addMonths, | ||
| } from 'date-fns'; | ||
| import { RRule, Frequency, Weekday } from 'rrule'; |
There was a problem hiding this comment.
Let's add rrule to spellcheck JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
We've decided to move the calculations for the timed digest delay to the main repo. This is what is this PR about.
Tested it locally and it works fine.
Why was this change needed?
Other information (Screenshots)