-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(application-generic): moved the timed digest delay calculations #3417
chore(application-generic): moved the timed digest delay calculations #3417
Conversation
… to the main repo
NV-2318 Move the timed digest delay calculations to the application-generic
Why? (Context)This is the decision we take because we have some problems checking out the submodules (with GitHub Desktop). What?Definition of Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟
[OrdinalValueEnum.SUNDAY]: RRule.SU, | ||
}; | ||
|
||
const ORDINAL_TO_RRULE_BYMONTHDAY = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const ORDINAL_TO_RRULE_BYMONTHDAY = { | |
const ORDINAL_TO_RRULE_BY_MONTH_DAY = { |
Thus we also avoid spellcheck warning.
packages/application-generic/src/services/calculate-delay/timed-digest-delay.service.ts
Outdated
Show resolved
Hide resolved
packages/application-generic/src/services/calculate-delay/timed-digest-delay.service.ts
Outdated
Show resolved
Hide resolved
addWeeks, | ||
addMonths, | ||
} from 'date-fns'; | ||
import { RRule, Frequency, Weekday } from 'rrule'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add rrule
to spellcheck JSON.
What change does this PR introduce?
We've decided to move the calculations for the timed digest delay to the main repo. This is what is this PR about.
Tested it locally and it works fine.
Why was this change needed?
Other information (Screenshots)