Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony Notifier in README.md #3633

Closed
wants to merge 1 commit into from

Conversation

wouter-toppy
Copy link
Contributor

@wouter-toppy wouter-toppy commented Jun 21, 2023

Docment the existance of the symfony-notifier component

What change does this PR introduce?

Provide the existance of the Symfony Notifier Component

Why was this change needed?

Closes: #3632

Other information (Screenshots)

Docment the existance of the symfony-notifier component
Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry but I consider this is not the right place to mention this integration with Novu, as the README is the main entry point to everything that related to Novu itself, what it does and how to use it.
@unicodeveloper would you mind to work with this contributor to find where is the best place we can showcase different tools or integrations implementing Novu for other languages and tools? 🙏🏻

@wouter-toppy
Copy link
Contributor Author

I am sorry but I consider this is not the right place to mention this integration with Novu, as the README is the main entry point to everything that related to Novu itself, what it does and how to use it. @unicodeveloper would you mind to work with this contributor to find where is the best place we can showcase different tools or integrations implementing Novu for other languages and tools? 🙏🏻

@p-fernandez I agreed the readme is not the ideal place. but I did't find a good place to mention these sort of tools that integrates novu. Perhaps @unicodeveloper has a correct answer.

@michaldziuba03
Copy link
Contributor

@wouter-toppy @unicodeveloper @p-fernandez

Maybe it should be mentioned in PHP SDK readme?

@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Jul 6, 2023
@scopsy
Copy link
Contributor

scopsy commented Jul 12, 2023

@wouter-toppy I aggree with @michaldziuba03 that a better location for this is on the PHP quick start guide and on the PHP SDK readme. Connecting also @unicodeveloper to further assist finding a good place for this. Closing the PR for now 🙏

@scopsy scopsy closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community stale Pull Request that needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Docs Feedback: Symfony Notifier Component
4 participants