Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier] Add Novu bridge #50414

Merged
merged 1 commit into from Jun 16, 2023
Merged

[Notifier] Add Novu bridge #50414

merged 1 commit into from Jun 16, 2023

Conversation

wouter-toppy
Copy link
Contributor

@wouter-toppy wouter-toppy commented May 24, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #50412
License MIT
Doc PR symfony/symfony-docs#18345

Provide Novu integration for Symfony Notifier.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@wouter-toppy wouter-toppy force-pushed the notifier-novu branch 5 times, most recently from 914e2fc to bf65025 Compare May 24, 2023 11:38
@welcoMattic
Copy link
Member

Hi @wouter-toppy! Thanks for your first contribution. As 6.3 is in feature-freeze, could you open your PR against 6.4 branch please? Thanks

@wouter-toppy
Copy link
Contributor Author

Hi @wouter-toppy! Thanks for your first contribution. As 6.3 is in feature-freeze, could you open your PR against 6.4 branch please? Thanks

Done

@wouter-toppy
Copy link
Contributor Author

@welcoMattic pipeline is still failing, but I cant see if that is a problem at my side.
tested the component, and it should be ready for merge to 6.4

@OskarStark OskarStark changed the title [Notifier] Add Novu Notifier Bridge [Notifier] Add Novu bridge May 24, 2023
@OskarStark OskarStark modified the milestones: 6.3, 6.4 May 24, 2023
wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull request May 25, 2023
wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull request May 26, 2023
@lyrixx lyrixx removed their request for review May 26, 2023 09:39
@wouter-toppy
Copy link
Contributor Author

@OskarStark anything i need to do to get this merged?

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend UnsupportedSchemeException and UnsupportedSchemeException, thanks

wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull request Jun 15, 2023
wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull request Jun 15, 2023
wouter-toppy added a commit to wouter-toppy/symfony that referenced this pull request Jun 15, 2023
@OskarStark
Copy link
Contributor

One last thing, can you please open a PR against symfony/recipes ? Thanks

@wouter-toppy
Copy link
Contributor Author

One last thing, can you please open a PR against symfony/recipes ? Thanks

@OskarStark symfony/recipes#1214

@fabpot
Copy link
Member

fabpot commented Jun 16, 2023

Thank you @wouter-toppy.

@fabpot fabpot merged commit 5bc63ad into symfony:6.4 Jun 16, 2023
7 of 9 checks passed
This was referenced Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notifier] Implement Novu notifier
5 participants