Add IP Pool Name In Integration #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
commented
Jun 22, 2023
| @@ -115,4 +116,24 @@ export class CredentialsDto { | |||
| @IsString() | |||
| @IsOptional() | |||
| webhookUrl?: string; | |||
|
|
|||
There was a problem hiding this comment.
missing attributes that i located due the implements ICredentials (in a hacky way)
djabarovgeorge
commented
Jun 22, 2023
|
|
||
| export class CredentialsDto { | ||
| export class CredentialsDto implements ICredentials { |
There was a problem hiding this comment.
this addition implements:
- is not helping with the compilation time with missing attributes because all of the attributes in ICredentials are optional.
- it will alert in case we provide an invalid type.
djabarovgeorge
commented
Jun 22, 2023
| @@ -328,32 +329,6 @@ export interface IIntegratedProvider { | |||
| novu?: boolean; | |||
| } | |||
|
|
|||
| export interface ICredentials { | |||
djabarovgeorge
commented
Jun 22, 2023
| @@ -152,34 +153,6 @@ export interface IIntegratedProvider { | |||
| novu?: boolean; | |||
| } | |||
|
|
|||
| export interface ICredentials { | |||
djabarovgeorge
commented
Jun 22, 2023
|
|
||
| import type { EnvironmentId } from '../environment'; | ||
| import type { OrganizationId } from '../organization'; | ||
| import { ChangePropsValueType } from '../../types/helpers'; | ||
|
|
||
| export interface ICredentials { |
djabarovgeorge
commented
Jun 22, 2023
| @@ -1,30 +1,6 @@ | |||
| export interface ICredentialsDto { | |||
djabarovgeorge
commented
Jun 22, 2023
| @@ -59,4 +30,6 @@ export class IntegrationEntity { | |||
| deletedBy: string; | |||
| } | |||
|
|
|||
| export type ICredentialsEntity = ICredentials; | |||
There was a problem hiding this comment.
was not sure what to call this one :/
because it is basically a type of interface, i left the I for now.
any thoughts about it?
There was a problem hiding this comment.
Decided to keep the "Entity" separation so we will have it in code. because one can change while the other one may not.
djabarovgeorge
commented
Jun 22, 2023
| @@ -1,4 +1,4 @@ | |||
| import { ICredentials } from '@novu/dal'; | |||
| import { ICredentials } from '@novu/shared'; | |||
There was a problem hiding this comment.
I thought that the shared one will do the work in the provider's packages.
p-fernandez
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Add ip pool name into the send grid integration.
Why was this change needed?
in order to provide the user the ability to add/update it.
Other information (Screenshots)
i refactored(moved to shared) the ICredentials by mistake we had too many duplications of it mostly mine fult.
i created an ICredentials in shared.
deleted some of the duplications.
currently created
typeof the interface because they were the same, it this type will need to change we change to update it to interface andimplementthe shared ICredentials.