-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added new workflows controller #3701
feat: added new workflows controller #3701
Conversation
Pull reviewers statsStats of the last 30 days for novu:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one is a finished state?
i am asking because i am wondering if we need to update all the usecases command names as well here? or will it be as a separate task?
Additionally, i think we need to recreate the e2e test as well, so we will make sure that this module is working as expected.
another small point i am not sure about, if we create such copy i think we should make sure that we talk about if we will maintain both copies and if not we need to alert the users we won't.
It is in another pr, there are 4 stacked |
yeah sorry just saw it as subtasks in linear. |
…files-to-workflow feat: renamed the usecases/commands
…efactor-workflows-tests
refactor: updated test cases for the workflow controller
45ff05e
into
nv-2405-workflows-crud-controller
What change does this PR introduce?
workflows
controller.Why was this change needed?
Other information (Screenshots)
This PR is a part of stacked PRs