Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new workflows controller #3701

Conversation

BiswaViraj
Copy link
Contributor

@BiswaViraj BiswaViraj commented Jul 2, 2023

What change does this PR introduce?

  • Created the new workflows controller.
  • Copy pasted the notification-template controller and renamed it.

Why was this change needed?

Other information (Screenshots)

This PR is a part of stacked PRs

@linear
Copy link

linear bot commented Jul 2, 2023

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Pull reviewers stats

Stats of the last 30 days for novu:

User Total reviews Time to review Total comments
p-fernandez 48 1h 35m 138
scopsy 16 24m 3
LetItRock 14 17h 47m 58
djabarovgeorge 14 1d 21h 5m 51
ainouzgali 10 43m 49
unicodeveloper 7 7d 8h 31m 96
davidsoderberg 5 15h 55m 3
BiswaViraj 2 10h 44m 1
jainpawan21 2 7h 59m 2
peoray 1 27m 1
michaldziuba03 1 10h 53m 1
Cliftonz 1 5d 54m 0

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one is a finished state?
i am asking because i am wondering if we need to update all the usecases command names as well here? or will it be as a separate task?
Additionally, i think we need to recreate the e2e test as well, so we will make sure that this module is working as expected.

another small point i am not sure about, if we create such copy i think we should make sure that we talk about if we will maintain both copies and if not we need to alert the users we won't.

@ainouzgali
Copy link
Contributor

Is this one is a finished state? i am asking because i am wondering if we need to update all the usecases command names as well here? or will it be as a separate task? Additionally, i think we need to recreate the e2e test as well, so we will make sure that this module is working as expected.

another small point i am not sure about, if we create such copy i think we should make sure that we talk about if we will maintain both copies and if not we need to alert the users we won't.

It is in another pr, there are 4 stacked

@djabarovgeorge
Copy link
Contributor

Is this one is a finished state? i am asking because i am wondering if we need to update all the usecases command names as well here? or will it be as a separate task? Additionally, i think we need to recreate the e2e test as well, so we will make sure that this module is working as expected.
another small point i am not sure about, if we create such copy i think we should make sure that we talk about if we will maintain both copies and if not we need to alert the users we won't.

It is in another pr, there are 4 stacked

yeah sorry just saw it as subtasks in linear.

Pablo Fernández and others added 3 commits July 7, 2023 17:54
…files-to-workflow

feat: renamed the usecases/commands
refactor: updated test cases for the workflow controller
@BiswaViraj BiswaViraj merged commit 45ff05e into nv-2405-workflows-crud-controller Jul 7, 2023
14 of 16 checks passed
@BiswaViraj BiswaViraj deleted the nv-2535-create-new-workflows-controller branch July 7, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants