refactor: marked the old notification-temlates controller, usecases a… #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd commands as deprecated
Pull reviewers statsStats of the last 30 days for novu:
|
BiswaViraj
commented
Jul 2, 2023
| @@ -43,7 +43,7 @@ import { CreateNotificationTemplateQuery } from './queries'; | |||
| @Controller('/notification-templates') | |||
| @UseInterceptors(ClassSerializerInterceptor) | |||
| @UseGuards(JwtAuthGuard) | |||
| @ApiTags('Workflows') | |||
| @ApiTags('Notification Templates') | |||
There was a problem hiding this comment.
Changed this to Notification templates to show it as deprecated on the swagger
There was a problem hiding this comment.
Where is it the new Swagger API for Workflows?
There was a problem hiding this comment.
It is in the different PR:#3701
BiswaViraj
commented
Jul 2, 2023
| @@ -59,6 +59,7 @@ export class NotificationTemplateController { | |||
| @ApiOperation({ | |||
| summary: 'Get workflows', | |||
There was a problem hiding this comment.
Suggested change
| summary: 'Get workflows', | |
| summary: 'Get notification templates', |
Should we change this description back to notification templates to show it in the swagger deprecated section?
This was referenced Jul 3, 2023
BiswaViraj
merged commit dab64ca
into
nv-2405-workflows-crud-controller
14 of 16 checks passed
BiswaViraj
deleted the
nv-2536-mark-old-templates-controller-as-deprecated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
deprecatedWhy was this change needed?
Other information (Screenshots)
This PR is a part of stacked PRs