fix: getContextPath did not work correctly when called in a browser #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to tidy up the TypeScript code, I haven't really used TypeScript before, and I'm sure it could be neater. |
|
Good catch |
scopsy
reviewed
Jul 20, 2023
Comment on lines
11
to
14
| // Determine if we are running in the browser or in node.js. If we are | ||
| // running in node.js, we will have access to the process.env object, | ||
| // otherwise we will have access to the window._env_ object to get the | ||
| // environment variables. |
There was a problem hiding this comment.
Seems like there is some eslint error here, i believe you would need to convert this to a multiline comment /**
There was a problem hiding this comment.
Thanks. I updated the code.
|
@scopsy Is there any hope in moving this forward? |
|
@DaveAtKeelvar yes! Sorry about that, everytime I approve the test runs and then while waiting forget to come backto it to merge. Added an alarm reminder 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
The function
getContextPathdoes not work correctly when called from inside a web browser.process.envis only available when the function is called within node.js. When called inside a web browser, we need to instead usewindow._env_to get access to the different context path variables.Why was this change needed?
To support custom context paths for Novu web
Other information (Screenshots)