optimization : merge two redis calls in api key authenticate #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
reviewed
Aug 16, 2023
| @@ -32,6 +32,7 @@ export enum CacheKeyPrefixEnum { | |||
| INTEGRATION = 'integration', | |||
| ENVIRONMENT_BY_API_KEY = 'environment_by_api_key', | |||
| GROUPED_BLUEPRINTS = 'grouped-blueprints', | |||
| USER_DATA = 'user_data_env_entity_user_entity', | |||
There was a problem hiding this comment.
Suggested change
| USER_DATA = 'user_data_env_entity_user_entity', | |
| AUTH_SERVICE = 'auth_service', |
Mainly because it is not our User data entity and we try to return multiple stuff, all related to a certain service.
A better name might be found than my suggestion, I reckon.
There was a problem hiding this comment.
i wanted to be more informative but awesome suggestion IMO thanks!
p-fernandez
approved these changes
Aug 17, 2023
scopsy
reviewed
Aug 17, 2023
| @@ -335,4 +337,31 @@ export class AuthService { | |||
| private async getSubscriber({ subscriberId, _environmentId }: { subscriberId: string; _environmentId: string }) { | |||
| return await this.subscriberRepository.findBySubscriberId(_environmentId, subscriberId); | |||
| } | |||
|
|
|||
| @CachedEntity({ | |||
There was a problem hiding this comment.
@djabarovgeorge what is our current default TTL?
There was a problem hiding this comment.
@scopsy I kept it as it is now (environment and user), it is 2 hours.
There was a problem hiding this comment.
We should clear it when the user email has changed, like in this use-case UpdateProfileEmail. Otherwise, the signed token might have an old email.
djabarovgeorge
deleted the
merge-two-redis-calls-in-api-key-authenticate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
merge two redis calls in api key to authenticate
Why was this change needed?
in order to reduce the redis call in trigger high load
Other information (Screenshots)