Stacked PR's of - Workflow override #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dal-repository' into NV-3117-create-workflowoverride-dal-repository
…dal-repository Create Workflow Override Repository
…ride-use-case Create workflow override use-case
…ride-use-case Update workflow override use-case
…e-use-case Get workflow override use-case
…ride-use-case Delete workflow override use-case
…es-use-case Get workflow overrides use case
…apply-overrides-during-the-trigger
…he-trigger Apply Workflow Overrides during the trigger
# Conflicts: # apps/api/src/app/events/usecases/parse-event-request/parse-event-request.usecase.ts # pnpm-lock.yaml
djabarovgeorge
commented
Nov 6, 2023
| _workflowId: 1, | ||
| _environmentId: 1, | ||
| }, | ||
| { unique: true } |
There was a problem hiding this comment.
Create it as unique so we could not create 2 overrides with the same tenant workflow.
djabarovgeorge
commented
Nov 6, 2023
| ); | ||
| } | ||
|
|
||
| @Put('/workflows/:workflowId/tenants/:tenantIdentifier') |
There was a problem hiding this comment.
I am still not sure if we should use here tenantIdentifier or _tenantId.
djabarovgeorge
commented
Nov 7, 2023
Comment on lines
+86
to
+87
| const message = workflowOverride ? 'Workflow is not active by workflow override' : 'Workflow is not active'; | ||
| Logger.log(message, LOG_CONTEXT); |
There was a problem hiding this comment.
I wonder if we should log more here because at the moment we do not and if we would want to debug something we would be missing the information as to why the trigger failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)