chore: make retention period configurable #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyaterletskaya
force-pushed
the
chore/make-retention-period-configurable
branch
from
2785507
to
51956c7
Compare
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
|
@scopsy @LetItRock @jainpawan21 could you please review? 🙂 |
LetItRock
reviewed
Mar 4, 2024
Comment on lines
56
to
64
| NOTIFICATION_RETENTION_DAYS: num({ | ||
| default: 30, | ||
| }), | ||
| MESSAGE_GENERIC_RETENTION_DAYS: num({ | ||
| default: 30, | ||
| }), | ||
| MESSAGE_IN_APP_RETENTION_DAYS: num({ | ||
| default: 365, | ||
| }), |
There was a problem hiding this comment.
let's maybe reuse the defaults from the constants you created in file libs/shared/src/consts/data-retention/index.ts ;)
There was a problem hiding this comment.
can we please introduce also the same changes on the api side?
There was a problem hiding this comment.
@LetItRock done ✅
LetItRock
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Allow the customization of retention periods
Why was this change needed?
#4570