-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(worker): add swc compiler for the worker service #5375
Conversation
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
❌ Deploy Preview for novu-design failed. Why did it fail? →
|
An interesting find I've noticed, when removing Should we consider just go with plain SWC without webpack? (Some path adjustments need to be done when importing the .env files for it to work, But should be manageable) |
This is slightly confusing, although we are a monorepo, we don't really have nest setup in a monorepo mode. Each app is treated independently without a centralized nest cli file. I think worth giving it a go without webpack. With webpack it seems doesn't really affect build time before and after the change. Or maybe i'm missing something. Have you had a chance to compare reaults of 'start:dev' compared to the next branch? |
@abrl91 yep! I think that's the way. Fixing the path errors should be relatively simple. It's usually just adding or removing the "../../" in the imports of those files to be relative to their new location in the First one is from the |
WalkthroughThe recent updates focus on enhancing the build process and environment handling in a worker application. Changes include the integration of SWC for faster builds, adjustments in the output directory for Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@scopsy I think you can re-review it :) |
@coderabbitai review |
@coderabbitai review |
@abrl91 Thank you for submitting this, unfortunately this does not cover internal changes we have recently made nor does if handle all of the services. We appreciate this PR however we are going to handle this upgrade internally. Thanks you! |
What change does this PR introduce?
Adding swc to the
Worker
Why was this change needed?
Integrating SWC with the Nest CLI has greatly enhanced the efficiency of the development workflow.
Other information (Screenshots)
Before:
After: