fix(web): Stop fetching context data on window focus #5568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for novu-design failed. Why did it fail? →
|
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Everytime the window gets focus, six requests are triggered to fetch orgs, users, changes, subscriptions, etc...
SokratisVidros
force-pushed
the
do_not_refresh_on_focus
branch
from
8cf2a87
to
274adf7
Compare
rifont
reviewed
Jun 18, 2024
| @@ -20,7 +20,6 @@ const queryClient = new QueryClient({ | |||
| queries: { | |||
| queryFn: defaultQueryFn as any, | |||
| refetchOnWindowFocus: false, | |||
There was a problem hiding this comment.
Refetch on window focus is already disabled on this line, it’s not clear what this change is achieving by removing the retry option. Could you elaborate?
There was a problem hiding this comment.
Please ignore. This change was pushed as part of the PW migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Every time the window gets focused, six requests are triggered to fetch orgs, users, changes, subscriptions, etc...
Screenshots
<img width="624" alt="Screenshot 2024-05-14 at 18 37 02" src="https://github.com/novuhq/novu/assets/1352422/64260d02-622a-4910-b3e9-0e3a6584f500"